feat(nano): include header-id when generating a sighash

[jansegre]

Motivation

When generating the sighash bytes for a nano-header the header-id is not included, but it is for a fee-header. This is an inconsistency, although there aren't any security implications.

Acceptance Criteria

• Include the header-id in get_sighash_bytes (or rather, don't exclude it)

Checklist

• If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

[github-actions]

Bencher Report

Branch	feat/nano-header-sighash-include-id
Testbed	ubuntu-22.04

Click to view all benchmark results

Benchmark	Latency	Benchmark Result minutes (m) (Result Δ%)	Lower Boundary minutes (m) (Limit %)	Upper Boundary minutes (m) (Limit %)
sync-v2 (up to 20000 blocks)	📈 view plot 🚷 view threshold	1.71 m (-1.29%) Baseline: 1.73 m	1.56 m (91.18%)	2.08 m (82.26%)

🐰 View full continuous benchmarking report in Bencher

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.13%. Comparing base (607e0a3) to head (033e2cd).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1478      +/-   ##
==========================================
+ Coverage   86.11%   86.13%   +0.02%     
==========================================
  Files         437      437              
  Lines       33968    33966       -2     
  Branches     5315     5315              
==========================================
+ Hits        29251    29257       +6     
+ Misses       3677     3673       -4     
+ Partials     1040     1036       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.