feat(nano): implement new get_current_code_blueprint_id syscall#1471
Merged
feat(nano): implement new get_current_code_blueprint_id syscall#1471
get_current_code_blueprint_id syscall#1471Conversation
fecfae3 to
f48f8ce
Compare
glevco
commented
Oct 16, 2025
f48f8ce to
a10ddb8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1471 +/- ##
==========================================
- Coverage 86.14% 86.05% -0.09%
==========================================
Files 437 437
Lines 34037 34044 +7
Branches 5323 5324 +1
==========================================
- Hits 29321 29298 -23
- Misses 3673 3694 +21
- Partials 1043 1052 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 task
jansegre
approved these changes
Oct 16, 2025
msbrogli
approved these changes
Oct 20, 2025
This was referenced Oct 20, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is a 2-in-1 PR:
BlueprintIdvalidation, meaning a contract would be able to call a method on itself when it should fail withNCInvalidSyscall('cannot call the same blueprint')instead. This is not a security problem, but rather a minor inconvenience as we could help developers prevent such mistakes.get_current_code_blueprint_idsyscall to get theBlueprintIdof the currently running code instead of currently running contract. The same method is used to fix the issue above.Acceptance Criteria
get_current_code_blueprint_idsyscall.BlueprintIdvalidation when making double proxy calls.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged