Skip to content

fix: add missing mempool cleanup rules#1464

Merged
msbrogli merged 1 commit intomasterfrom
fix/missing-mempool-cleanup
Oct 15, 2025
Merged

fix: add missing mempool cleanup rules#1464
msbrogli merged 1 commit intomasterfrom
fix/missing-mempool-cleanup

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Oct 14, 2025

Motivation

This PR adds missing mempool cleanup rules that must be in place because they're related to feature activations.

Acceptance Criteria

  • Add fee header and fee token version to the nano activation rule.
  • Add checkdatasig count activation rule.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Oct 14, 2025
@glevco glevco mentioned this pull request Oct 14, 2025
2 tasks
@glevco glevco moved this from Todo to In Progress (Done) in Hathor Network Oct 14, 2025
jansegre
jansegre previously approved these changes Oct 14, 2025
@glevco glevco moved this from In Progress (Done) to In Review (WIP) in Hathor Network Oct 14, 2025
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.11%. Comparing base (dce22bf) to head (aa3ff28).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
hathor/consensus/consensus.py 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1464      +/-   ##
==========================================
+ Coverage   86.01%   86.11%   +0.09%     
==========================================
  Files         435      435              
  Lines       33919    33940      +21     
  Branches     5297     5302       +5     
==========================================
+ Hits        29176    29227      +51     
+ Misses       3697     3675      -22     
+ Partials     1046     1038       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

msbrogli
msbrogli previously approved these changes Oct 14, 2025
@glevco glevco force-pushed the fix/missing-mempool-cleanup branch 2 times, most recently from 375c233 to 47cb8f4 Compare October 14, 2025 23:06
@glevco glevco dismissed stale reviews from msbrogli and jansegre via 121be20 October 15, 2025 01:19
@glevco glevco force-pushed the fix/missing-mempool-cleanup branch 2 times, most recently from 4b62c17 to 86332c5 Compare October 15, 2025 02:58
msbrogli
msbrogli previously approved these changes Oct 15, 2025
@glevco glevco force-pushed the fix/missing-mempool-cleanup branch from 56d30ce to aa3ff28 Compare October 15, 2025 15:59
@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Oct 15, 2025
@github-project-automation github-project-automation bot moved this from In Review (Done) to In Review (WIP) in Hathor Network Oct 15, 2025
@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Oct 15, 2025
@msbrogli msbrogli merged commit aa3ff28 into master Oct 15, 2025
7 of 8 checks passed
@msbrogli msbrogli deleted the fix/missing-mempool-cleanup branch October 15, 2025 16:30
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Oct 15, 2025
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Oct 15, 2025
@jansegre jansegre mentioned this pull request Oct 16, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants