Skip to content

fix: fullnode could stall and run out of memory#1462

Merged
jansegre merged 1 commit intomasterfrom
fix/possible-unbound-mempool-iter
Oct 14, 2025
Merged

fix: fullnode could stall and run out of memory#1462
jansegre merged 1 commit intomasterfrom
fix/possible-unbound-mempool-iter

Conversation

@jansegre
Copy link
Member

Motivation

Missing skip_neighbors could lead to iterating over the whole blockchain.

Acceptance Criteria

  • Add missing call to skip_neighbors in some places

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre requested review from glevco and msbrogli October 14, 2025 15:56
@jansegre jansegre self-assigned this Oct 14, 2025
@jansegre jansegre moved this from Todo to In Progress (Done) in Hathor Network Oct 14, 2025
msbrogli
msbrogli previously approved these changes Oct 14, 2025
@jansegre jansegre mentioned this pull request Oct 14, 2025
2 tasks
@jansegre jansegre moved this from In Progress (Done) to In Review (WIP) in Hathor Network Oct 14, 2025
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.01%. Comparing base (ae485dd) to head (dce22bf).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1462      +/-   ##
==========================================
- Coverage   86.02%   86.01%   -0.02%     
==========================================
  Files         435      435              
  Lines       33918    33919       +1     
  Branches     5297     5297              
==========================================
- Hits        29179    29176       -3     
- Misses       3693     3697       +4     
  Partials     1046     1046              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

glevco
glevco previously approved these changes Oct 14, 2025
@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Oct 14, 2025
@glevco glevco mentioned this pull request Oct 14, 2025
2 tasks
@jansegre jansegre force-pushed the fix/possible-unbound-mempool-iter branch from 562be94 to 61ad85d Compare October 14, 2025 19:26
@jansegre jansegre dismissed stale reviews from msbrogli and glevco via dce22bf October 14, 2025 19:46
@jansegre jansegre force-pushed the fix/possible-unbound-mempool-iter branch from 61ad85d to dce22bf Compare October 14, 2025 19:46
@github-project-automation github-project-automation bot moved this from In Review (Done) to In Review (WIP) in Hathor Network Oct 14, 2025
@jansegre jansegre merged commit 12b104a into master Oct 14, 2025
7 of 8 checks passed
@jansegre jansegre deleted the fix/possible-unbound-mempool-iter branch October 14, 2025 21:15
@github-project-automation github-project-automation bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Oct 14, 2025
@jansegre jansegre mentioned this pull request Oct 14, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants