fix: fullnode could stall and run out of memory#1462
Merged
Conversation
msbrogli
previously approved these changes
Oct 14, 2025
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1462 +/- ##
==========================================
- Coverage 86.02% 86.01% -0.02%
==========================================
Files 435 435
Lines 33918 33919 +1
Branches 5297 5297
==========================================
- Hits 29179 29176 -3
- Misses 3693 3697 +4
Partials 1046 1046 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
previously approved these changes
Oct 14, 2025
562be94 to
61ad85d
Compare
61ad85d to
dce22bf
Compare
glevco
approved these changes
Oct 14, 2025
msbrogli
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Missing
skip_neighborscould lead to iterating over the whole blockchain.Acceptance Criteria
skip_neighborsin some placesChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged