fix: add missing validation on token_history API#1461
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1461 +/- ##
==========================================
- Coverage 86.11% 86.09% -0.02%
==========================================
Files 437 437
Lines 34044 34047 +3
Branches 5324 5325 +1
==========================================
- Hits 29316 29313 -3
- Misses 3681 3686 +5
- Partials 1047 1048 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
force-pushed
the
fix/token-history-api
branch
2 times, most recently
from
c1451fd to
7df9fde
Compare
jansegre
approved these changes
Oct 20, 2025
msbrogli
approved these changes
Oct 20, 2025
2 tasks
glevco
force-pushed
the
fix/token-history-api
branch
from
7df9fde to
f98bd80
Compare
|
Bencher Report| Branch | fix/token-history-api |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.75 m(+0.82%)Baseline: 1.73 m | 1.56 m (89.27%) | 2.08 m (84.01%) |
glevco
force-pushed
the
fix/token-history-api
branch
from
f98bd80 to
aad71df
Compare
github-project-automation
bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A validation was missing on the
token_historyAPI, which ends up hitting an assertion in internal code and creating noise for the on call.Acceptance Criteria
tokens_historyAPI.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged