Merged
Conversation
|
| Branch | refactor/tests-reliability |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 2.01 m(+15.75%)Baseline: 1.73 m | 1.56 m (77.75%) | 2.08 m (96.46%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1458 +/- ##
==========================================
- Coverage 86.10% 86.06% -0.04%
==========================================
Files 437 437
Lines 33987 33967 -20
Branches 5316 5315 -1
==========================================
- Hits 29264 29235 -29
- Misses 3678 3684 +6
- Partials 1045 1048 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6f3b9d3 to
e40abc7
Compare
msbrogli
previously approved these changes
Oct 15, 2025
e40abc7 to
55d6ae5
Compare
msbrogli
approved these changes
Oct 20, 2025
2 tasks
jansegre
approved these changes
Oct 20, 2025
211d85f to
8a74dc2
Compare
8a74dc2 to
e6a4a6d
Compare
e6a4a6d to
a899921
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We had some tests running code that differs from what runs in production, so this PR addresses this by removing said code to make sure tests and production run equally.
Notably all
BlueprintTestCasetests, which are a great deal of nano-related tests, were using the memory trie instead of the RocksDB trie.Acceptance Criteria
vertex_handler.on_new_relayed_vertex, instead of a manual call to an internal method, which differed from what is called in production. Thenew_relayed_vertexarg, which was unused, is removed.MemoryNodeTrieStoreandNCMemoryStorageFactorywhich are not used in production, and update tests accordingly.TestRunnerso it's responsible for building its own dependencies.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged