tests(nano): add missing tests for new accessors#1457
Merged
Conversation
glevco
force-pushed
the
tests/accessors
branch
from
4f4442b to
224ea83
Compare
glevco
force-pushed
the
tests/accessors
branch
from
224ea83 to
c88797e
Compare
jansegre
approved these changes
Oct 10, 2025
|
Bencher Report| Branch | tests/accessors |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.96 m(+13.46%)Baseline: 1.73 m | 1.56 m (79.32%) | 2.07 m (94.55%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1457 +/- ##
=======================================
Coverage 85.97% 85.97%
=======================================
Files 436 436
Lines 33929 33929
Branches 5299 5299
=======================================
Hits 29171 29171
Misses 3704 3704
Partials 1054 1054 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msbrogli
approved these changes
Oct 10, 2025
github-project-automation
bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After new accessors introduced in PR #1451, some tests were missing. This PR adds them without any behavior changes.
Acceptance Criteria
ContractAccessor,ProxyAccessor, andInitializeMethodAccessor.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged