Skip to content

feat: fee payment update tokens indexes#1456

Merged
raul-oliveira merged 1 commit intomasterfrom
feat/fee-payment-token-index-update
Oct 13, 2025
Merged

feat: fee payment update tokens indexes#1456
raul-oliveira merged 1 commit intomasterfrom
feat/fee-payment-token-index-update

Conversation

@raul-oliveira
Copy link
Contributor

@raul-oliveira raul-oliveira commented Oct 10, 2025

resolves #1449

Motivation

Currently when a contract pay fees it only affect it's own balance. We should update the token index as well.

Acceptance Criteria

  • NCFee payments should update the token index similar to what we do for mint/melt operations

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@raul-oliveira raul-oliveira force-pushed the feat/fee-payment-token-index-update branch from a9c069b to f42c2c8 Compare October 10, 2025 01:49
@raul-oliveira raul-oliveira requested a review from glevco October 10, 2025 01:49
@github-actions
Copy link

github-actions bot commented Oct 10, 2025

🐰 Bencher Report

Branchfeat/fee-payment-token-index-update
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.82 m
(+5.15%)Baseline: 1.73 m
1.56 m
(85.59%)
2.08 m
(87.63%)
🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.97%. Comparing base (6ea3dc1) to head (4c41b08).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1456   +/-   ##
=======================================
  Coverage   85.97%   85.97%           
=======================================
  Files         434      435    +1     
  Lines       33829    33918   +89     
  Branches     5315     5297   -18     
=======================================
+ Hits        29083    29162   +79     
- Misses       3697     3703    +6     
- Partials     1049     1053    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@raul-oliveira raul-oliveira force-pushed the feat/fee-payment-token-index-update branch 2 times, most recently from 39c9a2b to 4ca371d Compare October 10, 2025 05:11
@raul-oliveira raul-oliveira self-assigned this Oct 10, 2025
@glevco glevco mentioned this pull request Oct 10, 2025
2 tasks
glevco
glevco previously approved these changes Oct 10, 2025
@glevco glevco moved this from Todo to In Review (WIP) in Hathor Network Oct 10, 2025
msbrogli
msbrogli previously approved these changes Oct 10, 2025
@raul-oliveira raul-oliveira dismissed stale reviews from msbrogli and glevco via 713ffb4 October 10, 2025 16:30
@raul-oliveira raul-oliveira force-pushed the feat/fee-payment-token-index-update branch from 713ffb4 to 0759dd4 Compare October 10, 2025 16:43
glevco
glevco previously approved these changes Oct 10, 2025
msbrogli
msbrogli previously approved these changes Oct 10, 2025
@raul-oliveira raul-oliveira dismissed stale reviews from msbrogli and glevco via a4557ad October 10, 2025 18:39
@raul-oliveira raul-oliveira force-pushed the feat/fee-payment-token-index-update branch 3 times, most recently from ef9041f to f176459 Compare October 10, 2025 18:51
@raul-oliveira raul-oliveira force-pushed the feat/fee-payment-token-index-update branch from f176459 to a0e333d Compare October 10, 2025 18:54
@raul-oliveira raul-oliveira enabled auto-merge (squash) October 10, 2025 21:12
@raul-oliveira raul-oliveira force-pushed the feat/fee-payment-token-index-update branch from a0e333d to 4c41b08 Compare October 13, 2025 16:39
@raul-oliveira raul-oliveira moved this from In Review (WIP) to In Review (Done) in Hathor Network Oct 13, 2025
@raul-oliveira raul-oliveira merged commit ae485dd into master Oct 13, 2025
6 of 8 checks passed
@raul-oliveira raul-oliveira deleted the feat/fee-payment-token-index-update branch October 13, 2025 17:28
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Oct 13, 2025
glevco pushed a commit that referenced this pull request Oct 15, 2025
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Oct 15, 2025
@jansegre jansegre mentioned this pull request Oct 16, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add index updates when paying fees

4 participants