feat: fee payment update tokens indexes#1456
Merged
raul-oliveira merged 1 commit intomasterfrom Oct 13, 2025
Merged
Conversation
a9c069b to
f42c2c8
Compare
|
| Branch | feat/fee-payment-token-index-update |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.82 m(+5.15%)Baseline: 1.73 m | 1.56 m (85.59%) | 2.08 m (87.63%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1456 +/- ##
=======================================
Coverage 85.97% 85.97%
=======================================
Files 434 435 +1
Lines 33829 33918 +89
Branches 5315 5297 -18
=======================================
+ Hits 29083 29162 +79
- Misses 3697 3703 +6
- Partials 1049 1053 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
39c9a2b to
4ca371d
Compare
glevco
previously approved these changes
Oct 10, 2025
msbrogli
previously approved these changes
Oct 10, 2025
713ffb4 to
0759dd4
Compare
glevco
previously approved these changes
Oct 10, 2025
msbrogli
previously approved these changes
Oct 10, 2025
ef9041f to
f176459
Compare
f176459 to
a0e333d
Compare
glevco
approved these changes
Oct 10, 2025
jansegre
approved these changes
Oct 13, 2025
msbrogli
approved these changes
Oct 13, 2025
a0e333d to
4c41b08
Compare
glevco
pushed a commit
that referenced
this pull request
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1449
Motivation
Currently when a contract pay fees it only affect it's own balance. We should update the token index as well.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged