Skip to content

feat(cli): add hidden CLI option to show nc-exec fail traces#1444

Merged
jansegre merged 1 commit intomasterfrom
feat/cli/nc-exec-fail-trace
Oct 15, 2025
Merged

feat(cli): add hidden CLI option to show nc-exec fail traces#1444
jansegre merged 1 commit intomasterfrom
feat/cli/nc-exec-fail-trace

Conversation

@jansegre
Copy link
Member

@jansegre jansegre commented Oct 3, 2025

Motivation

I've been doing this manually for a while, it's really helpful for debugging. With an option to enable it from the CLI it will be useful for users of Docker images, so no code change is needed to show the stack traces.

Acceptance Criteria

  • Add a hidden --nc-exec-fail-trace CLI option that translates to exc_info=True when logging a nano execution failure (the equivalent env var is HATHOR_NC_EXEC_FAIL_TRACE=true)

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre self-assigned this Oct 3, 2025
@jansegre jansegre requested a review from msbrogli as a code owner October 3, 2025 15:57
@jansegre jansegre moved this from Todo to In Progress (Done) in Hathor Network Oct 3, 2025
@github-actions
Copy link

github-actions bot commented Oct 3, 2025

🐰 Bencher Report

Branchfeat/cli/nc-exec-fail-trace
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.81 m
(+5.47%)Baseline: 1.72 m
1.55 m
(85.34%)
2.06 m
(87.89%)
🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.07%. Comparing base (a9cf795) to head (d2db923).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
hathor/consensus/block_consensus.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1444      +/-   ##
==========================================
+ Coverage   86.05%   86.07%   +0.02%     
==========================================
  Files         436      437       +1     
  Lines       34020    34037      +17     
  Branches     5319     5323       +4     
==========================================
+ Hits        29276    29298      +22     
+ Misses       3694     3689       -5     
  Partials     1050     1050              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jansegre jansegre moved this from In Progress (Done) to In Review (WIP) in Hathor Network Oct 6, 2025
@jansegre jansegre requested a review from glevco October 15, 2025 16:08
@jansegre jansegre mentioned this pull request Oct 15, 2025
2 tasks
@jansegre jansegre moved this from In Review (WIP) to In Review (Done) in Hathor Network Oct 15, 2025
@jansegre jansegre force-pushed the feat/cli/nc-exec-fail-trace branch from 268a27d to d2db923 Compare October 15, 2025 19:06
@jansegre jansegre merged commit e69ca48 into master Oct 15, 2025
1 of 2 checks passed
@jansegre jansegre deleted the feat/cli/nc-exec-fail-trace branch October 15, 2025 19:07
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Oct 15, 2025
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Oct 16, 2025
@jansegre jansegre mentioned this pull request Oct 16, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants