feat(cli): add hidden CLI option to show nc-exec fail traces#1444
Merged
feat(cli): add hidden CLI option to show nc-exec fail traces#1444
Conversation
|
| Branch | feat/cli/nc-exec-fail-trace |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.81 m(+5.47%)Baseline: 1.72 m | 1.55 m (85.34%) | 2.06 m (87.89%) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1444 +/- ##
==========================================
+ Coverage 86.05% 86.07% +0.02%
==========================================
Files 436 437 +1
Lines 34020 34037 +17
Branches 5319 5323 +4
==========================================
+ Hits 29276 29298 +22
+ Misses 3694 3689 -5
Partials 1050 1050 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pedroferreira1
approved these changes
Oct 3, 2025
msbrogli
approved these changes
Oct 15, 2025
2 tasks
268a27d to
d2db923
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I've been doing this manually for a while, it's really helpful for debugging. With an option to enable it from the CLI it will be useful for users of Docker images, so no code change is needed to show the stack traces.
Acceptance Criteria
--nc-exec-fail-traceCLI option that translates toexc_info=Truewhen logging a nano execution failure (the equivalent env var isHATHOR_NC_EXEC_FAIL_TRACE=true)Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged