feat(verification): Forbid transactions in the mempool that spend from voided outputs that are confirmed

[msbrogli]

Motivation

After nano is activated, nano transactions that fail execution will be voided and confirmed by blocks. This scenario was impossible before (except for soft voided transaction) but now they should be way more common. This prevents blocks from confirming transactions that will certainly be voided.

Acceptance Criteria

1. Reject transactions in the mempool that spend from voided outputs that are confirmed.

Checklist

• If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

[github-actions]

Bencher Report

Branch	feat/verification-input-voided-and-confirmed
Testbed	ubuntu-22.04

🚨 1 Alert

Benchmark	Measure Units	View	Benchmark Result (Result Δ%)	Upper Boundary (Limit %)
sync-v2 (up to 20000 blocks)	Latency minutes (m)	📈 plot 🚷 threshold 🚨 alert (🔔)	2.44 m (+41.51%) Baseline: 1.73 m	2.07 m (117.93%)

Click to view all benchmark results

Benchmark	Latency	Benchmark Result minutes (m) (Result Δ%)	Lower Boundary minutes (m) (Limit %)	Upper Boundary minutes (m) (Limit %)
sync-v2 (up to 20000 blocks)	📈 view plot 🚷 view threshold 🚨 view alert (🔔)	2.44 m (+41.51%) Baseline: 1.73 m	1.55 m (63.60%)	2.07 m (117.93%)

🐰 View full continuous benchmarking report in Bencher

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.97%. Comparing base (2387a69) to head (37061c6).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1443      +/-   ##
==========================================
- Coverage   86.03%   85.97%   -0.07%     
==========================================
  Files         434      434              
  Lines       33739    33742       +3     
  Branches     5291     5292       +1     
==========================================
- Hits        29029    29009      -20     
- Misses       3673     3686      +13     
- Partials     1037     1047      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.