Skip to content

feat(nano): Add a mempool verification to check allowed actions#1440

Merged
msbrogli merged 1 commit intomasterfrom
feat/nano-mempool-verify-allowed-actions
Oct 9, 2025
Merged

feat(nano): Add a mempool verification to check allowed actions#1440
msbrogli merged 1 commit intomasterfrom
feat/nano-mempool-verify-allowed-actions

Conversation

@msbrogli
Copy link
Member

@msbrogli msbrogli commented Oct 2, 2025

Motivation

As nano tx with not allowed actions are certainly going to fail execution, there's no need to accept them to enter the mempool.

Acceptance Criteria

  1. Forbid nano tx with not allowed actions in the mempool.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@msbrogli msbrogli self-assigned this Oct 2, 2025
@msbrogli msbrogli moved this to In Progress (WIP) in Hathor Network Oct 2, 2025
@msbrogli msbrogli force-pushed the feat/nano-mempool-verify-allowed-actions branch from 949769a to 85b6f29 Compare October 9, 2025 17:21
@github-actions
Copy link

github-actions bot commented Oct 9, 2025

🐰 Bencher Report

Branchfeat/nano-mempool-verify-allowed-actions
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.97 m
(+14.32%)Baseline: 1.73 m
1.55 m
(78.73%)
2.07 m
(95.26%)
🐰 View full continuous benchmarking report in Bencher

@msbrogli msbrogli force-pushed the feat/nano-mempool-verify-allowed-actions branch 4 times, most recently from b15cfd4 to 9d3da87 Compare October 9, 2025 20:26
@msbrogli msbrogli force-pushed the feat/nano-mempool-verify-allowed-actions branch from 9d3da87 to 83c2ab0 Compare October 9, 2025 20:27
@msbrogli msbrogli marked this pull request as ready for review October 9, 2025 20:27
@msbrogli msbrogli requested a review from jansegre as a code owner October 9, 2025 20:27
@msbrogli msbrogli moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Oct 9, 2025
@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.97%. Comparing base (ccde97f) to head (83c2ab0).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1440   +/-   ##
=======================================
  Coverage   85.96%   85.97%           
=======================================
  Files         434      434           
  Lines       33791    33798    +7     
  Branches     5305     5307    +2     
=======================================
+ Hits        29050    29057    +7     
  Misses       3694     3694           
  Partials     1047     1047           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@msbrogli msbrogli requested a review from glevco October 9, 2025 21:12
@github-project-automation github-project-automation bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Oct 9, 2025
@jansegre jansegre moved this from In Review (WIP) to In Review (Done) in Hathor Network Oct 9, 2025
@msbrogli msbrogli merged commit 83c2ab0 into master Oct 9, 2025
8 checks passed
@msbrogli msbrogli deleted the feat/nano-mempool-verify-allowed-actions branch October 9, 2025 21:18
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Oct 9, 2025
@jansegre jansegre mentioned this pull request Oct 13, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Oct 15, 2025
@jansegre jansegre mentioned this pull request Oct 16, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants