feat(nano): Add a mempool verification to check allowed actions#1440
Merged
feat(nano): Add a mempool verification to check allowed actions#1440
Conversation
949769a to
85b6f29
Compare
|
| Branch | feat/nano-mempool-verify-allowed-actions |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.97 m(+14.32%)Baseline: 1.73 m | 1.55 m (78.73%) | 2.07 m (95.26%) |
b15cfd4 to
9d3da87
Compare
9d3da87 to
83c2ab0
Compare
jansegre
approved these changes
Oct 9, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1440 +/- ##
=======================================
Coverage 85.96% 85.97%
=======================================
Files 434 434
Lines 33791 33798 +7
Branches 5305 5307 +2
=======================================
+ Hits 29050 29057 +7
Misses 3694 3694
Partials 1047 1047 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
approved these changes
Oct 9, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As nano tx with not allowed actions are certainly going to fail execution, there's no need to accept them to enter the mempool.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged