feat(verification): Limit the number of conflicts in mempool

[msbrogli]

Acceptance Criteria

1. Limit the number of conflicts in mempool to 8. So, any other transaction that would increase the number of conflicts is rejected.

Checklist

• If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

[jansegre]

From what I understood from the acceptance criteria was that if the mempool has 8 transactions with conflicts (or maybe 8 conflicts in total if counting the individual conflicts each transaction has), a transaction that would increase that count would not be accepted.

This implementation seems to count whether a single transaction has more than 8 conflicts with transactions in the mempool, and if that's the case transaction would not be accepted into the mempool.

Is that correct? Both of those restrictions make sense, but the latter would allow 100 transactions with conflicts in the mempool, as long as individually each tx has at most 8 conflicts.

[msbrogli]

Nice. The ambiguity happened to suggest another restriction that makes sense. I'll add this new restriction in this PR. Thanks!

[msbrogli]

Done! Can you review it again, please?

[github-actions]

Bencher Report

Branch	feat/mempool-too-many-conflicts
Testbed	ubuntu-22.04

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

• Latency (nanoseconds (ns))

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results

Benchmark	Latency	minutes (m)
sync-v2 (up to 20000 blocks)	📈 view plot ⚠️ NO THRESHOLD	1.98 m

🐰 View full continuous benchmarking report in Bencher

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.86%. Comparing base (4d5742a) to head (b9b9bc9).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1436      +/-   ##
==========================================
- Coverage   85.88%   85.86%   -0.02%     
==========================================
  Files         431      431              
  Lines       33274    33287      +13     
  Branches     5215     5218       +3     
==========================================
+ Hits        28576    28581       +5     
- Misses       3660     3665       +5     
- Partials     1038     1041       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.