Skip to content

fix(nano): API was not processing initialize method correctly#1433

Merged
jansegre merged 1 commit intomasterfrom
fix/nano/blueprint-resource-initialize-method
Sep 26, 2025
Merged

fix(nano): API was not processing initialize method correctly#1433
jansegre merged 1 commit intomasterfrom
fix/nano/blueprint-resource-initialize-method

Conversation

@jansegre
Copy link
Member

Motivation

Blueprint endpoint was always returning empty arguments for initialize method.

Acceptance Criteria

  • Update test so the issue can show up
  • Use inspect.signature instead of inspect.getfullargspec because it can properly take into account wrapped functions

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@github-actions
Copy link

🐰 Bencher Report

Branchfix/nano/blueprint-resource-initialize-method
Testbedubuntu-22.04

🚨 1 Alert

BenchmarkMeasure
Units
ViewBenchmark Result
(Result Δ%)
Upper Boundary
(Limit %)
sync-v2 (up to 20000 blocks)Latency
minutes (m)
📈 plot
🚷 threshold
🚨 alert (🔔)
2.11 m
(+23.29%)Baseline: 1.71 m
2.05 m
(102.74%)

Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
🚨 view alert (🔔)
2.11 m
(+23.29%)Baseline: 1.71 m
1.54 m
(73.00%)
2.05 m
(102.74%)

🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.82%. Comparing base (297959c) to head (db25eaa).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
hathor/nanocontracts/resources/blueprint.py 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1433      +/-   ##
==========================================
- Coverage   85.83%   85.82%   -0.02%     
==========================================
  Files         431      431              
  Lines       33278    33264      -14     
  Branches     5225     5213      -12     
==========================================
- Hits        28564    28548      -16     
  Misses       3673     3673              
- Partials     1041     1043       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jansegre jansegre mentioned this pull request Sep 26, 2025
2 tasks
@jansegre jansegre merged commit 5a1f2db into master Sep 26, 2025
7 of 8 checks passed
@jansegre jansegre deleted the fix/nano/blueprint-resource-initialize-method branch September 26, 2025 20:35
@github-project-automation github-project-automation bot moved this from Todo to Waiting to be deployed in Hathor Network Sep 26, 2025
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Sep 26, 2025
@jansegre jansegre mentioned this pull request Oct 7, 2025
2 tasks
@jansegre jansegre mentioned this pull request Oct 16, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants