fix(nano): Fix NCCreationResource to get contract information from the global state#1425
Merged
fix(nano): Fix NCCreationResource to get contract information from the global state#1425
Conversation
|
| Branch | fix/nano-nc_creation-api |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 2.05 m(+19.72%)Baseline: 1.71 m | 1.54 m (75.18%) | 2.05 m (99.77%) |
774adbf to
49b2dca
Compare
jansegre
previously approved these changes
Sep 24, 2025
49b2dca to
7e26c0c
Compare
5a4b4c6 to
5548cde
Compare
5548cde to
33a2888
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1425 +/- ##
==========================================
- Coverage 85.77% 85.76% -0.02%
==========================================
Files 431 431
Lines 33115 33133 +18
Branches 5193 5196 +3
==========================================
+ Hits 28406 28416 +10
- Misses 3671 3677 +6
- Partials 1038 1040 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jansegre
approved these changes
Sep 25, 2025
This was referenced Sep 25, 2025
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
NCCreationResource was previously getting contract information from the vertex that created that contract. But this does not work for contracts created by contracts. This PR fixes that.
Acceptance Criteria
created_atis set to zero.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged