Skip to content

fix(nano): compatibility with testnet-hotel#1422

Merged
jansegre merged 1 commit intomasterfrom
fix/nano/testnet-hotel-compat
Sep 23, 2025
Merged

fix(nano): compatibility with testnet-hotel#1422
jansegre merged 1 commit intomasterfrom
fix/nano/testnet-hotel-compat

Conversation

@jansegre
Copy link
Member

Motivation

What was the motivation for the changes in this PR?

Acceptance Criteria

  • Include here all things that this PR should solve

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.75%. Comparing base (08fcb0f) to head (486fed2).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
hathor/nanocontracts/fields/container.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1422      +/-   ##
==========================================
- Coverage   85.85%   85.75%   -0.10%     
==========================================
  Files         430      430              
  Lines       33070    33070              
  Branches     5173     5173              
==========================================
- Hits        28392    28359      -33     
- Misses       3645     3672      +27     
- Partials     1033     1039       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

msbrogli
msbrogli previously approved these changes Sep 22, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Review (WIP) in Hathor Network Sep 22, 2025
@jansegre jansegre mentioned this pull request Sep 23, 2025
2 tasks
@jansegre jansegre marked this pull request as ready for review September 23, 2025 20:05
@jansegre jansegre changed the base branch from release-candidate to hotfixes September 23, 2025 21:08
@jansegre jansegre dismissed msbrogli’s stale review September 23, 2025 21:08

The base branch was changed.

@jansegre jansegre changed the base branch from hotfixes to master September 23, 2025 21:08
@jansegre jansegre force-pushed the fix/nano/testnet-hotel-compat branch from 8081b99 to 486fed2 Compare September 23, 2025 21:11
@github-actions
Copy link

🐰 Bencher Report

Branchfix/nano/testnet-hotel-compat
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.98 m
(+16.87%)Baseline: 1.69 m
1.52 m
(77.01%)
2.03 m
(97.39%)
🐰 View full continuous benchmarking report in Bencher

@jansegre jansegre merged commit 3ef58ea into master Sep 23, 2025
7 checks passed
@jansegre jansegre deleted the fix/nano/testnet-hotel-compat branch September 23, 2025 21:21
@github-project-automation github-project-automation bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Sep 23, 2025
@jansegre jansegre mentioned this pull request Sep 24, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants