fix(nano): avoid exception when generating json#1421
Merged
Conversation
|
| Branch | fix/nano/json-exception |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.76 m(+1.73%)Baseline: 1.73 m | 1.56 m (88.47%) | 2.08 m (84.78%) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1421 +/- ##
==========================================
- Coverage 86.12% 86.11% -0.01%
==========================================
Files 437 437
Lines 33966 33967 +1
Branches 5315 5316 +1
==========================================
- Hits 29253 29251 -2
- Misses 3672 3674 +2
- Partials 1041 1042 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Not needed after #1423 |
796f453 to
70b7f15
Compare
70b7f15 to
0b9c70f
Compare
glevco
approved these changes
Oct 27, 2025
msbrogli
approved these changes
Oct 27, 2025
This was referenced Oct 27, 2025
Merged
This was referenced Dec 2, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Calling a method from a voided contract could make generating the JSON of a transaction fail.
Acceptance Criteria
accept_failed_execution: booltonano_header.get_blueprint_idso JSON can be generatedChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged