Conversation
|
Bencher Report| Branch | feat/cli/nc-dump |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.98 m(+16.69%)Baseline: 1.70 m | 1.53 m (77.13%) | 2.04 m (97.24%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1420 +/- ##
==========================================
- Coverage 85.79% 85.77% -0.03%
==========================================
Files 430 430
Lines 33070 33070
Branches 5173 5173
==========================================
- Hits 28373 28365 -8
- Misses 3659 3666 +7
- Partials 1038 1039 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jansegre
force-pushed
the
feat/cli/nc-dump
branch
from
d74cf14 to
a09ff17
Compare
2 tasks
jansegre
force-pushed
the
feat/cli/nc-dump
branch
from
a09ff17 to
542aac9
Compare
msbrogli
previously approved these changes
Sep 23, 2025
jansegre
force-pushed
the
feat/cli/nc-dump
branch
from
542aac9 to
efe6b87
Compare
msbrogli
previously approved these changes
Sep 23, 2025
jansegre
force-pushed
the
feat/cli/nc-dump
branch
from
efe6b87 to
4d047ca
Compare
github-project-automation
bot
moved this from In Progress (Done)
to Waiting to be deployed
in Hathor Network
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently there's no simple way to easily view the whole nano-storage.
Acceptance Criteria
x-nc-dumpcommand that exports all unique patricia-tries starting from the best block in a text format is simple to inspect.Example output (this isn't a complete dump, it's just to showcase the format):
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged