fix(nano): initialization of block root ids#1418
Merged
Conversation
|
Bencher Report| Branch | fix/nano/init-block-root-id |
| Testbed | ubuntu-22.04 |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | Latency | minutes (m) |
|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot | 1.97 m |
glevco
force-pushed
the
fix/nano/init-block-root-id
branch
4 times, most recently
from
f86c983 to
0efaec3
Compare
msbrogli
previously approved these changes
Sep 17, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1418 +/- ##
==========================================
- Coverage 85.83% 85.75% -0.08%
==========================================
Files 430 430
Lines 32973 33061 +88
Branches 5161 5171 +10
==========================================
+ Hits 28301 28353 +52
- Misses 3639 3668 +29
- Partials 1033 1040 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jansegre
approved these changes
Sep 18, 2025
2 tasks
msbrogli
approved these changes
Sep 18, 2025
jansegre
force-pushed
the
fix/nano/init-block-root-id
branch
from
56f8a4f to
bbc930a
Compare
github-project-automation
bot
moved this from In Review (WIP)
to Waiting to be deployed
in Hathor Network
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There's a bug in the initialization of block root IDs that makes the sync become too slow. This PR fixes it. Before this PR,
_nc_initialize_emptywas called only for the genesis and for the first active block. Instead, it should be called for every block where nano is not active.Acceptance Criteria
_nc_initialize_emptyfor every block non-active block, instead of just the genesis and the first active block.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged