Skip to content

feat(nano): key-mangling continuation#1417

Merged
jansegre merged 1 commit intomasterfrom
feat/nano/key-mangling2
Oct 8, 2025
Merged

feat(nano): key-mangling continuation#1417
jansegre merged 1 commit intomasterfrom
feat/nano/key-mangling2

Conversation

@jansegre
Copy link
Member

@jansegre jansegre commented Sep 17, 2025

Motivation

When merging #1312 we left some changes to be made in a future PR, this is the PR.

Acceptance Criteria

  • Do not initialize fields implicitly.
  • Fail execution of initialize call if there are fields that were not initialized.
  • Add more complete tests with more nested container combinations.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre requested review from glevco and msbrogli September 17, 2025 19:18
@jansegre jansegre self-assigned this Sep 17, 2025
@jansegre jansegre moved this from Todo to In Progress (WIP) in Hathor Network Sep 17, 2025
@github-actions
Copy link

github-actions bot commented Sep 19, 2025

🐰 Bencher Report

Branchfeat/nano/key-mangling2
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.96 m
(+14.01%)Baseline: 1.72 m
1.55 m
(78.94%)
2.07 m
(95.01%)
🐰 View full continuous benchmarking report in Bencher

@jansegre jansegre force-pushed the feat/nano/key-mangling2 branch from ef4cbeb to f98ef07 Compare September 24, 2025 16:59
@github-project-automation github-project-automation bot moved this from In Progress (WIP) to In Review (WIP) in Hathor Network Sep 25, 2025
@jansegre jansegre mentioned this pull request Sep 26, 2025
2 tasks
@jansegre jansegre moved this from In Review (WIP) to In Progress (WIP) in Hathor Network Sep 30, 2025
@jansegre jansegre force-pushed the feat/nano/key-mangling2 branch 4 times, most recently from 056aa60 to 3f2477c Compare October 3, 2025 15:15
@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

❌ Patch coverage is 69.81132% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.87%. Comparing base (49a9ac1) to head (70e9c43).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
hathor/nanocontracts/fields/field.py 45.45% 6 Missing ⚠️
hathor/nanocontracts/runner/runner.py 66.66% 2 Missing and 2 partials ⚠️
hathor/nanocontracts/fields/container.py 80.00% 2 Missing ⚠️
hathor/nanocontracts/fields/deque_container.py 50.00% 2 Missing ⚠️
hathor/nanocontracts/fields/dict_container.py 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1417      +/-   ##
==========================================
- Coverage   85.96%   85.87%   -0.10%     
==========================================
  Files         434      434              
  Lines       33673    33675       +2     
  Branches     5280     5278       -2     
==========================================
- Hits        28948    28919      -29     
- Misses       3684     3703      +19     
- Partials     1041     1053      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

msbrogli
msbrogli previously approved these changes Oct 6, 2025
@jansegre jansegre moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Oct 6, 2025
@jansegre jansegre marked this pull request as ready for review October 6, 2025 18:53
@jansegre jansegre force-pushed the feat/nano/key-mangling2 branch from 3f2477c to f80f53f Compare October 6, 2025 18:54
glevco
glevco previously approved these changes Oct 6, 2025
msbrogli
msbrogli previously approved these changes Oct 7, 2025
@glevco glevco moved this from In Progress (Done) to In Review (WIP) in Hathor Network Oct 7, 2025
@jansegre jansegre merged commit d708ede into master Oct 8, 2025
8 checks passed
@jansegre jansegre deleted the feat/nano/key-mangling2 branch October 8, 2025 14:31
@github-project-automation github-project-automation bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Oct 8, 2025
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Oct 15, 2025
@jansegre jansegre mentioned this pull request Oct 16, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants