Merged
Conversation
jansegre
commented
Sep 18, 2025
jansegre
commented
Sep 18, 2025
0152577 to
ef4cbeb
Compare
|
| Branch | feat/nano/key-mangling2 |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.96 m(+14.01%)Baseline: 1.72 m | 1.55 m (78.94%) | 2.07 m (95.01%) |
ef4cbeb to
f98ef07
Compare
msbrogli
requested changes
Sep 25, 2025
2 tasks
056aa60 to
3f2477c
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1417 +/- ##
==========================================
- Coverage 85.96% 85.87% -0.10%
==========================================
Files 434 434
Lines 33673 33675 +2
Branches 5280 5278 -2
==========================================
- Hits 28948 28919 -29
- Misses 3684 3703 +19
- Partials 1041 1053 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msbrogli
previously approved these changes
Oct 6, 2025
3f2477c to
f80f53f
Compare
glevco
previously approved these changes
Oct 6, 2025
f80f53f to
a5ec9e2
Compare
msbrogli
previously approved these changes
Oct 7, 2025
a5ec9e2 to
70e9c43
Compare
glevco
approved these changes
Oct 7, 2025
msbrogli
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When merging #1312 we left some changes to be made in a future PR, this is the PR.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged