chore(nano): remove deprecated ctx.timestamp#1413
Merged
Conversation
luislhl
reviewed
Sep 16, 2025
Comment on lines
93
to
95
| except (BlueprintDoesNotExist, OCBBlueprintNotConfirmed): | ||
| request.setResponseCode(404) | ||
| error_response = ErrorResponse(success=False, error=f'Blueprint not found: {params.blueprint_id}') |
Contributor
There was a problem hiding this comment.
Should the error message be different for the new exception? Is it not a problem to return "Blueprint not found" in this error?
msbrogli
previously approved these changes
Sep 17, 2025
glevco
force-pushed
the
chore/nano/remove-ctx-timestamp
branch
from
0df051e to
a7308a0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1413 +/- ##
==========================================
- Coverage 86.03% 85.92% -0.12%
==========================================
Files 432 432
Lines 32822 32819 -3
Branches 5114 5113 -1
==========================================
- Hits 28239 28200 -39
- Misses 3575 3599 +24
- Partials 1008 1020 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jansegre
previously approved these changes
Sep 24, 2025
msbrogli
previously approved these changes
Sep 25, 2025
msbrogli
force-pushed
the
chore/nano/remove-ctx-timestamp
branch
from
a7308a0 to
b49773a
Compare
msbrogli
approved these changes
Sep 25, 2025
jansegre
approved these changes
Sep 25, 2025
github-project-automation
bot
moved this from In Review (WIP)
to Waiting to be deployed
in Hathor Network
|
Bencher Report| Branch | chore/nano/remove-ctx-timestamp |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.94 m(+13.77%)Baseline: 1.70 m | 1.53 m (79.11%) | 2.04 m (94.81%) |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Remove deprecated property in preparation for nano on mainnet.
Acceptance Criteria
ctx.timestampproperty.OCBBlueprintNotConfirmedhandling on blueprint API.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged