feat(p2p): add commands to query the nano state of a peer#1411
Merged
feat(p2p): add commands to query the nano state of a peer#1411
Conversation
|
| Branch | feat/p2p/nano-state-commands |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.99 m(+17.73%)Baseline: 1.69 m | 1.52 m (76.45%) | 2.03 m (98.10%) |
de05263 to
59d802f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1411 +/- ##
==========================================
- Coverage 86.03% 85.84% -0.20%
==========================================
Files 432 432
Lines 32822 32917 +95
Branches 5114 5125 +11
==========================================
+ Hits 28239 28257 +18
- Misses 3575 3634 +59
- Partials 1008 1026 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 tasks
59d802f to
f0563b6
Compare
msbrogli
previously approved these changes
Sep 17, 2025
f0563b6 to
f48640d
Compare
f48640d to
17f0e9a
Compare
msbrogli
previously approved these changes
Sep 18, 2025
17f0e9a to
0d34dc3
Compare
msbrogli
previously approved these changes
Sep 18, 2025
0d34dc3 to
a191628
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently there's no way to check whether 2 peers have the same nano-state.
Acceptance Criteria
GET_BLOCK_NC_ROOT_ID/BLOCK_NC_ROOT_IDto query the root node-id of a given block-hashGET_NC_DB_NODE/NC_DB_NODEto query the node-data of a given node-id, a maximal response has about 34478 bytes which fits into the protocol max line length limit of ~65KBChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged