Skip to content

feat(nano): implement feature activation handling#1410

Merged
glevco merged 1 commit intomasterfrom
feat/nano/feature-activation
Sep 15, 2025
Merged

feat(nano): implement feature activation handling#1410
glevco merged 1 commit intomasterfrom
feat/nano/feature-activation

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Sep 11, 2025

Motivation

Implement the ability to use Feature Activation for Blocks for activating Nano Contracts.

Acceptance Criteria

  • Update Nano feature activation to use block mechanism instead of transaction mechanism. This is compatible with testnet-hotel because it's less restrictive.
  • Change nano config on mainnet from DISABLED to FEATURE_ACTIVATION. The feature config itself it not yet set.
  • Refactor block consensus to initialize the feature activation block with an empty trie, while maintaining compatibility with previous code.
  • On consensus, change _compute_vertices_that_became_invalid and related functions to methods.
  • Add a nano activation mempool rule to remove invalid nano transactions.
  • Refactor nano-related verification to use a verification param that is set
    • using the parent block for txs that come inside a block
    • using the best block for mempool txs.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco moved this from Todo to In Progress (Done) in Hathor Network Sep 11, 2025
msbrogli
msbrogli previously approved these changes Sep 11, 2025
@github-project-automation github-project-automation bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Sep 11, 2025
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.97%. Comparing base (57f9bdc) to head (2a42f4c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1410      +/-   ##
==========================================
+ Coverage   85.91%   85.97%   +0.05%     
==========================================
  Files         432      432              
  Lines       32791    32822      +31     
  Branches     5112     5114       +2     
==========================================
+ Hits        28174    28218      +44     
+ Misses       3599     3592       -7     
+ Partials     1018     1012       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Sep 11, 2025
@glevco glevco force-pushed the fix/nano/clean-up-mempool branch from f361221 to b234b33 Compare September 12, 2025 16:00
@glevco glevco force-pushed the feat/nano/feature-activation branch from 964d216 to abb533f Compare September 12, 2025 16:12
@glevco glevco changed the base branch from fix/nano/clean-up-mempool to master September 12, 2025 16:41
@glevco glevco dismissed msbrogli’s stale review September 12, 2025 16:41

The base branch was changed.

@glevco glevco force-pushed the feat/nano/feature-activation branch from abb533f to 2a42f4c Compare September 12, 2025 16:43
@github-project-automation github-project-automation bot moved this from In Review (Done) to In Review (WIP) in Hathor Network Sep 15, 2025
@glevco glevco merged commit 8f23d02 into master Sep 15, 2025
12 of 16 checks passed
@glevco glevco deleted the feat/nano/feature-activation branch September 15, 2025 15:42
@github-project-automation github-project-automation bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Sep 15, 2025
@jansegre jansegre mentioned this pull request Sep 17, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Sep 18, 2025
@jansegre jansegre mentioned this pull request Sep 24, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants