fix(nano): clean up mempool after reorg#1409
Merged
Conversation
|
| Branch | fix/nano/clean-up-mempool |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.87 m(+10.88%)Baseline: 1.69 m | 1.52 m (81.17%) | 2.02 m (92.40%) |
msbrogli
approved these changes
Sep 11, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1409 +/- ##
==========================================
+ Coverage 85.86% 85.88% +0.01%
==========================================
Files 432 432
Lines 32760 32791 +31
Branches 5102 5112 +10
==========================================
+ Hits 28129 28162 +33
+ Misses 3610 3609 -1
+ Partials 1021 1020 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f361221 to
b234b33
Compare
jansegre
approved these changes
Sep 12, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Clean up NC txs that became invalid after a reorg, removing them from the mempool.
Acceptance Criteria
compute_vertices_that_became_invalidfromTransactionStorageto the consensus and change its algorithm:compute_vertices_that_became_invalid. Also, that function was called only when the best height decreased, but now it's called for every reorg.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged