Skip to content

feat(nano): remove create_token syscall alias#1404

Merged
jansegre merged 1 commit intomasterfrom
feat/nano/remove-compat-alias
Sep 19, 2025
Merged

feat(nano): remove create_token syscall alias#1404
jansegre merged 1 commit intomasterfrom
feat/nano/remove-compat-alias

Conversation

@jansegre
Copy link
Member

WARNING: this PR breaks compatibility with nano on testnet-hotel

Motivation

A temporary alias was added, it should be removed before nano on mainnet, but not before a last release with testnet-hotel compatibility.

Acceptance Criteria

  • Remove self.syscall.create_token alias to self.syscall.create_deposit_token available to Blueprints

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre requested review from glevco and msbrogli September 11, 2025 15:25
@jansegre jansegre self-assigned this Sep 11, 2025
@jansegre jansegre moved this from Todo to In Progress (Done) in Hathor Network Sep 11, 2025
@github-actions
Copy link

github-actions bot commented Sep 11, 2025

🐰 Bencher Report

Branchfeat/nano/remove-compat-alias
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.97 m
(+16.60%)Baseline: 1.69 m
1.52 m
(77.18%)
2.03 m
(97.17%)
🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.77%. Comparing base (1ee5b31) to head (c5e0a2d).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1404      +/-   ##
==========================================
+ Coverage   85.75%   85.77%   +0.01%     
==========================================
  Files         430      430              
  Lines       33060    33070      +10     
  Branches     5171     5173       +2     
==========================================
+ Hits        28352    28366      +14     
+ Misses       3669     3665       -4     
  Partials     1039     1039              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jansegre jansegre force-pushed the feat/nano/remove-compat-alias branch from 7f30a86 to be7f08c Compare September 11, 2025 16:21
@glevco glevco moved this from In Progress (Done) to In Review (WIP) in Hathor Network Sep 11, 2025
@jansegre jansegre moved this from In Review (WIP) to In Review (Done) in Hathor Network Sep 11, 2025
@jansegre jansegre force-pushed the feat/nano/remove-compat-alias branch from be7f08c to 1ee5b31 Compare September 18, 2025 21:42
@jansegre jansegre force-pushed the feat/nano/remove-compat-alias branch from 1ee5b31 to c5e0a2d Compare September 19, 2025 14:49
@jansegre jansegre merged commit 11de11c into master Sep 19, 2025
5 of 7 checks passed
@jansegre jansegre deleted the feat/nano/remove-compat-alias branch September 19, 2025 14:54
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Sep 19, 2025
@jansegre jansegre mentioned this pull request Sep 26, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Sep 26, 2025
@jansegre jansegre mentioned this pull request Oct 16, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants