Skip to content

refactor(nano): move all imports to hathor#1401

Merged
jansegre merged 1 commit intomasterfrom
refactor/nano/imports
Sep 25, 2025
Merged

refactor(nano): move all imports to hathor#1401
jansegre merged 1 commit intomasterfrom
refactor/nano/imports

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Sep 10, 2025

Motivation

Unify hathor OCB imports in a single module, for simplicity. This is a breaking change with testnet-hotel.

Acceptance Criteria

  • Move all OCB allowed imports to the new hathor module.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Sep 10, 2025
@glevco glevco moved this from Todo to In Progress (Done) in Hathor Network Sep 10, 2025
@github-actions
Copy link

github-actions bot commented Sep 10, 2025

🐰 Bencher Report

Branchrefactor/nano/imports
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.95 m
(+14.67%)Baseline: 1.70 m
1.53 m
(78.48%)
2.04 m
(95.56%)
🐰 View full continuous benchmarking report in Bencher

@glevco glevco force-pushed the refactor/nano/imports branch 3 times, most recently from 3505592 to e960b95 Compare September 17, 2025 15:26
@glevco glevco changed the title refactor(nano): move all imports to hathor.contracts refactor(nano): move all imports to hathor Sep 17, 2025
@glevco glevco force-pushed the refactor/nano/imports branch from e960b95 to c808354 Compare September 17, 2025 15:32
@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.77%. Comparing base (96e5fcf) to head (852f0c8).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
hathor/nanocontracts/resources/blueprint.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1401      +/-   ##
==========================================
- Coverage   85.84%   85.77%   -0.08%     
==========================================
  Files         431      431              
  Lines       33096    33097       +1     
  Branches     5179     5179              
==========================================
- Hits        28412    28389      -23     
- Misses       3651     3667      +16     
- Partials     1033     1041       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

msbrogli
msbrogli previously approved these changes Sep 18, 2025
@jansegre jansegre force-pushed the refactor/nano/imports branch 2 times, most recently from 2a6e82f to 96e5fcf Compare September 24, 2025 20:03
jansegre
jansegre previously approved these changes Sep 24, 2025
msbrogli
msbrogli previously approved these changes Sep 25, 2025
@github-project-automation github-project-automation bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Sep 25, 2025
@jansegre jansegre dismissed stale reviews from msbrogli and themself via 86d253b September 25, 2025 15:28
@jansegre jansegre force-pushed the refactor/nano/imports branch from 96e5fcf to 86d253b Compare September 25, 2025 15:28
@jansegre jansegre moved this from In Review (WIP) to In Review (Done) in Hathor Network Sep 25, 2025
jansegre
jansegre previously approved these changes Sep 25, 2025
msbrogli
msbrogli previously approved these changes Sep 25, 2025
@github-project-automation github-project-automation bot moved this from In Review (Done) to In Review (WIP) in Hathor Network Sep 25, 2025
@jansegre jansegre merged commit 8e6ea50 into master Sep 25, 2025
6 of 7 checks passed
@jansegre jansegre deleted the refactor/nano/imports branch September 25, 2025 15:33
@github-project-automation github-project-automation bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Sep 25, 2025
@jansegre jansegre mentioned this pull request Sep 26, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Sep 26, 2025
@jansegre jansegre mentioned this pull request Oct 16, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants