refactor(indexes): improve mempool tips index#1399
Merged
Conversation
7868224 to
e2a6e7d
Compare
|
| Branch | refactor/mempool-tips-index |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.90 m(+12.69%)Baseline: 1.68 m | 1.51 m (79.87%) | 2.02 m (93.91%) |
jansegre
approved these changes
Sep 9, 2025
msbrogli
approved these changes
Sep 9, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1399 +/- ##
==========================================
- Coverage 85.91% 85.90% -0.02%
==========================================
Files 431 431
Lines 32701 32700 -1
Branches 5095 5096 +1
==========================================
- Hits 28095 28090 -5
- Misses 3588 3595 +7
+ Partials 1018 1015 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Improve handling of mempool tips on the index.
Acceptance Criteria
vertex.nameon graphviz and on vertexrepr, which is useful for tests that use theDAGBuilder.mempool_tips.updatein vertex handler and move it toindexes.update.mempool_tips.updatemethod:removeargument from an optional bool to just a bool. Since the code is only ever called with eitherTrueorNone, we could remove the currentFalsecase and use it instead ofNone, allowing simplification of the logic. Also, it's renamed toforce_remove.any_non_voidedfunction instead of repeating it manually.E731 do not assign a lambda expression, use a def. It was unnecessary and inconvenient.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged