feat(nano): Add salt to tokens created by contracts#1398
Merged
Conversation
msbrogli
commented
Sep 9, 2025
|
| Branch | feat/token-creation-salt |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.84 m(+9.05%)Baseline: 1.68 m | 1.52 m (82.53%) | 2.02 m (90.87%) |
004d4c6 to
8bbee69
Compare
glevco
previously approved these changes
Sep 9, 2025
ff85f1f to
1364e28
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1398 +/- ##
==========================================
+ Coverage 85.88% 85.94% +0.05%
==========================================
Files 432 432
Lines 32745 32746 +1
Branches 5102 5102
==========================================
+ Hits 28122 28142 +20
+ Misses 3603 3591 -12
+ Partials 1020 1013 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0e905d5 to
778af18
Compare
jansegre
approved these changes
Sep 10, 2025
glevco
approved these changes
Sep 10, 2025
778af18 to
1c51c26
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add a salt to the token creation by contracts. This change allows contracts to create multiple tokens with the same token symbol and was requested by a use case.
Acceptance Criteria
salt: bytesas an optional attribute when creating a token usingself.syscall.create_token(...). Default is no salt.salt: bytesas an optional attribute inderive_child_token_id(). Default is no salt.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged