feat(nano): remove support for using __blueprint__ in OCB code#1397
Merged
feat(nano): remove support for using __blueprint__ in OCB code#1397
Conversation
1 task
|
Bencher Report| Branch | feat/nano/remove-blueprint-dunder-support |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.97 m(+16.06%)Baseline: 1.70 m | 1.53 m (77.54%) | 2.04 m (96.72%) |
jansegre
force-pushed
the
feat/nano/remove-blueprint-dunder-support
branch
2 times, most recently
from
e7f5897 to
0c45086
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1397 +/- ##
==========================================
+ Coverage 85.77% 85.79% +0.02%
==========================================
Files 430 430
Lines 33070 33054 -16
Branches 5173 5172 -1
==========================================
- Hits 28365 28360 -5
+ Misses 3666 3657 -9
+ Partials 1039 1037 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
reviewed
Sep 11, 2025
| """Verify that the script defines a __blueprint__ attribute.""" | ||
| """Verify that the script seemingly exports a blueprint.""" | ||
| blueprint_ast = self._get_python_code_ast(tx) | ||
| search_name = _SearchName(BLUEPRINT_EXPORT_NAME) |
Contributor
There was a problem hiding this comment.
I think we can remove the _SearchName class
|
|
||
| def _verify_has_blueprint_attr(self, tx: OnChainBlueprint) -> None: | ||
| """Verify that the script defines a __blueprint__ attribute.""" | ||
| """Verify that the script seemingly exports a blueprint.""" |
Member
Author
There was a problem hiding this comment.
Yes, "seemingly", because @export could have been used in a class defined inside a function, or with an invalid class that is not a Blueprint. So at most we can say that it seemingly exports a blueprint, but we won't be sure until we execute the code.
| self.manager.vertex_handler.on_new_relayed_vertex(blueprint) | ||
| assert isinstance(cm.exception.__cause__, OCBInvalidScript) | ||
| assert cm.exception.args[0] == 'full validation failed: __blueprint__ is not a class' | ||
| assert cm.exception.args[0] == 'full validation failed: Could not find a main Blueprint definition' |
Contributor
There was a problem hiding this comment.
I think this error should keep the previous, correct message
Member
Author
There was a problem hiding this comment.
Since this message could bubble up to blueprint devs, I wanted to avoid using __blueprint__ because now it's only an internal detail.
jansegre
force-pushed
the
feat/nano/remove-blueprint-dunder-support
branch
2 times, most recently
from
afe1de8 to
f68f2e7
Compare
msbrogli
previously approved these changes
Sep 23, 2025
jansegre
force-pushed
the
feat/nano/remove-blueprint-dunder-support
branch
from
f68f2e7 to
bfbc318
Compare
github-project-automation
bot
moved this from In Review (WIP)
to Waiting to be deployed
in Hathor Network
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#1395 introduced the use of
@exportto set the main blueprint class of a module, but leaves the old method (__blueprint__ = MyBlueprint) as acceptable.Acceptance Criteria
__blueprint__@exportChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged