feat(nano): restrict usage of float and complex numbers#1396
Merged
Conversation
|
| Branch | feat/nano/restrict-float |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.94 m(+15.08%)Baseline: 1.69 m | 1.52 m (78.20%) | 2.03 m (95.90%) |
0cc75da to
c5f1a61
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1396 +/- ##
==========================================
- Coverage 85.83% 85.77% -0.06%
==========================================
Files 430 430
Lines 33061 33071 +10
Branches 5171 5173 +2
==========================================
- Hits 28377 28367 -10
- Misses 3650 3665 +15
- Partials 1034 1039 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
previously approved these changes
Sep 8, 2025
msbrogli
previously approved these changes
Sep 8, 2025
c5f1a61 to
a0c2788
Compare
a0c2788 to
070fd4d
Compare
glevco
previously approved these changes
Sep 11, 2025
070fd4d to
338a532
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WARNING: this causes breakage with testnet-hotel, because some of the published OCBs use the float division operator.
Motivation
Some syntax still allows float and complex numbers, which could lead to different results in different hardware. We should lift these restrictions when we have a deterministic float implementation.
Acceptance Criteria
/) in Blueprint codeChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged