feat(nano): reduce NC_EVENT max size to 1KiB#1394
Merged
Conversation
glevco
approved these changes
Sep 5, 2025
msbrogli
approved these changes
Sep 5, 2025
|
| Branch | feat/reduce-nc-event-max-size |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.80 m(+7.56%)Baseline: 1.68 m | 1.51 m (83.67%) | 2.01 m (89.63%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1394 +/- ##
==========================================
- Coverage 85.90% 85.86% -0.05%
==========================================
Files 430 430
Lines 32570 32570
Branches 5072 5072
==========================================
- Hits 27979 27965 -14
- Misses 3580 3592 +12
- Partials 1011 1013 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The previous limit of 100KiB is high, especially because there's no way to select specific contracts when enabling
NC_EVENTs.Acceptance Criteria
100KiBto1KiBChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged