Skip to content

feat(nano): reduce NC_EVENT max size to 1KiB#1394

Merged
jansegre merged 1 commit intomasterfrom
feat/reduce-nc-event-max-size
Sep 9, 2025
Merged

feat(nano): reduce NC_EVENT max size to 1KiB#1394
jansegre merged 1 commit intomasterfrom
feat/reduce-nc-event-max-size

Conversation

@jansegre
Copy link
Member

@jansegre jansegre commented Sep 5, 2025

Motivation

The previous limit of 100KiB is high, especially because there's no way to select specific contracts when enabling NC_EVENTs.

Acceptance Criteria

  • Reduce limit from 100KiB to 1KiB

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre requested review from glevco and msbrogli September 5, 2025 19:15
@jansegre jansegre self-assigned this Sep 5, 2025
@jansegre jansegre moved this from Todo to In Progress (Done) in Hathor Network Sep 5, 2025
@github-project-automation github-project-automation bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Sep 5, 2025
@github-actions
Copy link

github-actions bot commented Sep 5, 2025

🐰 Bencher Report

Branchfeat/reduce-nc-event-max-size
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.80 m
(+7.56%)Baseline: 1.68 m
1.51 m
(83.67%)
2.01 m
(89.63%)
🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.86%. Comparing base (ee93952) to head (063a25a).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1394      +/-   ##
==========================================
- Coverage   85.90%   85.86%   -0.05%     
==========================================
  Files         430      430              
  Lines       32570    32570              
  Branches     5072     5072              
==========================================
- Hits        27979    27965      -14     
- Misses       3580     3592      +12     
- Partials     1011     1013       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jansegre jansegre moved this from In Review (WIP) to In Review (Done) in Hathor Network Sep 8, 2025
@jansegre jansegre merged commit 12464d2 into master Sep 9, 2025
8 checks passed
@jansegre jansegre deleted the feat/reduce-nc-event-max-size branch September 9, 2025 13:37
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Sep 9, 2025
@jansegre jansegre mentioned this pull request Sep 11, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Sep 18, 2025
@jansegre jansegre mentioned this pull request Sep 24, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants