Skip to content

feat: added scenario with a transaction chain that is voided#1392

Open
andreabadesso wants to merge 3 commits intomasterfrom
feat/voiding-chain-scenario
Open

feat: added scenario with a transaction chain that is voided#1392
andreabadesso wants to merge 3 commits intomasterfrom
feat/voiding-chain-scenario

Conversation

@andreabadesso
Copy link
Copy Markdown
Contributor

Motivation

What was the motivation for the changes in this PR?

Acceptance Criteria

  • Include here all things that this PR should solve

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 4, 2025

🐰 Bencher Report

Branchfeat/voiding-chain-scenario
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.95 m
(+15.70%)Baseline: 1.69 m
1.52 m
(77.79%)
2.03 m
(96.42%)
🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 23.07692% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.87%. Comparing base (ee93952) to head (9828383).
⚠️ Report is 278 commits behind head on master.

Files with missing lines Patch % Lines
hathor/wallet/base_wallet.py 23.07% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1392      +/-   ##
==========================================
- Coverage   85.90%   85.87%   -0.03%     
==========================================
  Files         430      432       +2     
  Lines       32570    32802     +232     
  Branches     5072     5117      +45     
==========================================
+ Hits        27979    28169     +190     
- Misses       3580     3614      +34     
- Partials     1011     1019       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andreabadesso andreabadesso self-assigned this Sep 4, 2025
@andreabadesso andreabadesso moved this from Todo to In Progress (Done) in Hathor Network Sep 4, 2025
@andreabadesso andreabadesso moved this from In Progress (Done) to In Progress (WIP) in Hathor Network Sep 4, 2025
@andreabadesso andreabadesso force-pushed the feat/voiding-chain-scenario branch 2 times, most recently from 7d3d3d1 to 00632d7 Compare September 9, 2025 13:53
@andreabadesso andreabadesso force-pushed the feat/voiding-chain-scenario branch 2 times, most recently from f35bd5d to 985ef74 Compare September 12, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant