feat: added scenario with a transaction chain that is voided#1392
Open
andreabadesso wants to merge 3 commits intomasterfrom
Open
feat: added scenario with a transaction chain that is voided#1392andreabadesso wants to merge 3 commits intomasterfrom
andreabadesso wants to merge 3 commits intomasterfrom
Conversation
|
| Branch | feat/voiding-chain-scenario |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.95 m(+15.70%)Baseline: 1.69 m | 1.52 m (77.79%) | 2.03 m (96.42%) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1392 +/- ##
==========================================
- Coverage 85.90% 85.87% -0.03%
==========================================
Files 430 432 +2
Lines 32570 32802 +232
Branches 5072 5117 +45
==========================================
+ Hits 27979 28169 +190
- Misses 3580 3614 +34
- Partials 1011 1019 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7d3d3d1 to
00632d7
Compare
f35bd5d to
985ef74
Compare
985ef74 to
9828383
Compare
3 tasks
eb416fa to
21d7909
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
What was the motivation for the changes in this PR?
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged