feat(nano): add str utils for Address class#1391
Merged
Conversation
|
| Branch | feat/nano/str-address-utils |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.86 m(+10.76%)Baseline: 1.68 m | 1.51 m (81.26%) | 2.02 m (92.30%) |
glevco
previously approved these changes
Sep 3, 2025
7f9398a to
1f6f05f
Compare
msbrogli
approved these changes
Sep 9, 2025
1f6f05f to
bf7b5c2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1391 +/- ##
==========================================
- Coverage 85.91% 85.86% -0.05%
==========================================
Files 430 430
Lines 32570 32583 +13
Branches 5072 5074 +2
==========================================
- Hits 27981 27979 -2
- Misses 3575 3587 +12
- Partials 1014 1017 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
approved these changes
Sep 9, 2025
bf7b5c2 to
e00c5c7
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently there isn't a way to convert to/from string and addresses in Blueprint code. Instead of simply exposing the internal functions to do it, this PR exposes a friendlier API.
Acceptance Criteria
str(address)support foraddress: AddressAddress.from_str(raw_address)Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged