fix(nano): fix nano_contracts_enabled on /version api#1387
Merged
Conversation
jansegre
approved these changes
Aug 27, 2025
|
| Branch | feat/nano/enabled-api |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.91 m(+14.23%)Baseline: 1.67 m | 1.51 m (78.79%) | 2.01 m (95.19%) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1387 +/- ##
==========================================
- Coverage 85.82% 85.81% -0.02%
==========================================
Files 429 429
Lines 32423 32433 +10
Branches 5057 5056 -1
==========================================
+ Hits 27828 27831 +3
- Misses 3583 3587 +4
- Partials 1012 1015 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pedroferreira1
approved these changes
Aug 27, 2025
jansegre
pushed a commit
that referenced
this pull request
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
/versionAPI was indirectly changed to return a string enum instead of a bool for thenano_contracts_enabledkey, which made all clients believe the nano feature is active for all networks. This PR fixes this.Acceptance Criteria
is_nano_activelogic into its own utils function.nano_contracts_enabledkey on the/versionAPI to return a bool instead of an string enum.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged