feat(nano): remove Context.timestamp and move BlockData to Context#1381
Merged
feat(nano): remove Context.timestamp and move BlockData to Context#1381
Conversation
|
Bencher Report| Branch | feat/nano/improve-context |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.90 m(+13.29%)Baseline: 1.67 m | 1.51 m (79.44%) | 2.01 m (94.41%) |
msbrogli
previously approved these changes
Aug 22, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1381 +/- ##
==========================================
+ Coverage 85.62% 85.69% +0.06%
==========================================
Files 429 429
Lines 32450 32444 -6
Branches 5068 5066 -2
==========================================
+ Hits 27786 27802 +16
+ Misses 3631 3616 -15
+ Partials 1033 1026 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jansegre
requested changes
Aug 22, 2025
glevco
force-pushed
the
feat/nano/improve-context
branch
from
7ed2b83 to
35ddac0
Compare
jansegre
approved these changes
Aug 26, 2025
msbrogli
approved these changes
Aug 26, 2025
github-project-automation
bot
moved this from In Review (Done)
to In Review (WIP)
in Hathor Network
github-project-automation
bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Move
BlockDatafrom insideVertexDatato its ownblockattribute onContext. Remove theContext.timestampattribute as the block timestamp should be used.ATTENTION: This may be a breaking change if any existing blueprint is using the refactored attributes.
Acceptance Criteria
Context, removing thetimestampattribute and moving block data from vertex to the context itself.actions_listimmutable.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged