Skip to content

tests(nano): increase coverage#1377

Merged
glevco merged 1 commit intomasterfrom
tests/nano/increase-cov
Aug 27, 2025
Merged

tests(nano): increase coverage#1377
glevco merged 1 commit intomasterfrom
tests/nano/increase-cov

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Aug 21, 2025

Motivation

This PR improves test coverage of important nano or consensus related code, mostly by implementing new tests.

Acceptance Criteria

  • Add # pragma: no cover comments on unreachable code branches.
  • Add tests for allowed match syntax on OCBs.
  • Add test for invalid Python syntax on OCBs.
  • Add test for reorg with NC txs that have conflicts with other txs.
  • Add missing tests for restricted signature mechanism on OCBs.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@github-actions
Copy link

github-actions bot commented Aug 21, 2025

🐰 Bencher Report

Branchtests/nano/increase-cov
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
2.00 m
(+19.35%)Baseline: 1.67 m
1.51 m
(75.41%)
2.01 m
(99.46%)
🐰 View full continuous benchmarking report in Bencher

@glevco glevco moved this from Todo to In Progress (Done) in Hathor Network Aug 21, 2025
@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.83%. Comparing base (b2775be) to head (074e74c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1377      +/-   ##
==========================================
+ Coverage   85.68%   85.83%   +0.15%     
==========================================
  Files         429      429              
  Lines       32444    32423      -21     
  Branches     5066     5057       -9     
==========================================
+ Hits        27799    27830      +31     
+ Misses       3619     3583      -36     
+ Partials     1026     1010      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glevco glevco moved this from In Progress (Done) to In Review (WIP) in Hathor Network Aug 21, 2025
@glevco glevco force-pushed the tests/nano/increase-cov branch from b68305e to d4d1e17 Compare August 22, 2025 11:37
@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Aug 26, 2025
@glevco glevco force-pushed the tests/nano/increase-cov branch from d4d1e17 to 074e74c Compare August 26, 2025 15:36
@glevco glevco merged commit d6690ec into master Aug 27, 2025
8 checks passed
@glevco glevco deleted the tests/nano/increase-cov branch August 27, 2025 16:27
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Aug 27, 2025
@jansegre jansegre mentioned this pull request Sep 11, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Sep 18, 2025
@jansegre jansegre mentioned this pull request Sep 24, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants