Conversation
|
| Branch | tests/nano/increase-cov |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 2.00 m(+19.35%)Baseline: 1.67 m | 1.51 m (75.41%) | 2.01 m (99.46%) |
glevco
commented
Aug 21, 2025
jansegre
approved these changes
Aug 21, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1377 +/- ##
==========================================
+ Coverage 85.68% 85.83% +0.15%
==========================================
Files 429 429
Lines 32444 32423 -21
Branches 5066 5057 -9
==========================================
+ Hits 27799 27830 +31
+ Misses 3619 3583 -36
+ Partials 1026 1010 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b68305e to
d4d1e17
Compare
msbrogli
approved these changes
Aug 26, 2025
d4d1e17 to
074e74c
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR improves test coverage of important nano or consensus related code, mostly by implementing new tests.
Acceptance Criteria
# pragma: no covercomments on unreachable code branches.matchsyntax on OCBs.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged