Skip to content

chore: Fix typo in StrNCType#1375

Merged
msbrogli merged 1 commit intomasterfrom
chore/fix-typo-error-message
Aug 21, 2025
Merged

chore: Fix typo in StrNCType#1375
msbrogli merged 1 commit intomasterfrom
chore/fix-typo-error-message

Conversation

@msbrogli
Copy link
Member

Motivation

What was the motivation for the changes in this PR?

Acceptance Criteria

  • Include here all things that this PR should solve

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@msbrogli msbrogli requested a review from jansegre as a code owner August 21, 2025 16:26
@github-actions
Copy link

🐰 Bencher Report

Branchchore/fix-typo-error-message
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.84 m
(+10.29%)Baseline: 1.67 m
1.50 m
(81.60%)
2.00 m
(91.91%)
🐰 View full continuous benchmarking report in Bencher

@msbrogli msbrogli self-assigned this Aug 21, 2025
@msbrogli msbrogli moved this from Todo to In Progress (Done) in Hathor Network Aug 21, 2025
@github-project-automation github-project-automation bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Aug 21, 2025
@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.70%. Comparing base (786cf34) to head (a4ad960).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1375      +/-   ##
==========================================
+ Coverage   85.66%   85.70%   +0.04%     
==========================================
  Files         429      429              
  Lines       32444    32444              
  Branches     5068     5068              
==========================================
+ Hits        27792    27807      +15     
+ Misses       3621     3612       -9     
+ Partials     1031     1025       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@msbrogli msbrogli merged commit a4ad960 into master Aug 21, 2025
6 of 8 checks passed
@msbrogli msbrogli deleted the chore/fix-typo-error-message branch August 21, 2025 17:19
@github-project-automation github-project-automation bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Aug 21, 2025
@jansegre jansegre mentioned this pull request Sep 11, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Sep 18, 2025
@jansegre jansegre mentioned this pull request Sep 24, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants