Skip to content

fix(nano): fix NC context on tx API#1368

Merged
glevco merged 1 commit intomasterfrom
fix/tx-api-nc-context
Aug 19, 2025
Merged

fix(nano): fix NC context on tx API#1368
glevco merged 1 commit intomasterfrom
fix/tx-api-nc-context

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Aug 19, 2025

Motivation

Fix compatibility with existing APIs.

Acceptance Criteria

  • Readd address attribute to Context.to_json(), for compatibility with existing APIs.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@github-actions
Copy link

🐰 Bencher Report

Branchfix/tx-api-nc-context
Testbedubuntu-22.04

🚨 1 Alert

BenchmarkMeasure
Units
ViewBenchmark Result
(Result Δ%)
Upper Boundary
(Limit %)
sync-v2 (up to 20000 blocks)Latency
minutes (m)
📈 plot
🚷 threshold
🚨 alert (🔔)
1.83 m
(+10.31%)Baseline: 1.66 m
1.82 m
(100.28%)

Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
🚨 view alert (🔔)
1.83 m
(+10.31%)Baseline: 1.66 m
1.49 m
(81.59%)
1.82 m
(100.28%)

🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.60%. Comparing base (93ded98) to head (d807a7f).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
hathor/nanocontracts/context.py 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1368      +/-   ##
==========================================
- Coverage   85.63%   85.60%   -0.04%     
==========================================
  Files         429      429              
  Lines       32433    32440       +7     
  Branches     5067     5069       +2     
==========================================
- Hits        27773    27769       -4     
- Misses       3632     3635       +3     
- Partials     1028     1036       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glevco glevco moved this from Todo to In Progress (Done) in Hathor Network Aug 19, 2025
@github-project-automation github-project-automation bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Aug 19, 2025
@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Aug 19, 2025
@glevco glevco merged commit a7ca60b into master Aug 19, 2025
12 of 14 checks passed
@glevco glevco deleted the fix/tx-api-nc-context branch August 19, 2025 21:01
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Aug 19, 2025
This was referenced Aug 20, 2025
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants