fix(nano): state API regression after ctx.address refactor#1367
Merged
fix(nano): state API regression after ctx.address refactor#1367
Conversation
|
| Branch | fix/state-api-regression |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.82 m(+9.61%)Baseline: 1.66 m | 1.49 m (82.11%) | 1.83 m (99.64%) |
a63fb50 to
756cccf
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1367 +/- ##
==========================================
- Coverage 85.65% 85.65% -0.01%
==========================================
Files 429 429
Lines 32440 32439 -1
Branches 5069 5068 -1
==========================================
- Hits 27788 27785 -3
- Misses 3624 3627 +3
+ Partials 1028 1027 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
756cccf to
41544fd
Compare
glevco
approved these changes
Aug 20, 2025
41544fd to
e0842ff
Compare
msbrogli
approved these changes
Aug 20, 2025
This was referenced Aug 20, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When we refactored
ctx.addressintoctx.caller_idwe also introduced specialized classesAddress(bytes),VertexId(bytes), etc, and those broke aif type(value) is bytescheck, either way that check was not the correct way to do it.Acceptance Criteria
Address,VertexIdand othersChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged