Skip to content

fix(nano): state API regression after ctx.address refactor#1367

Merged
jansegre merged 1 commit intomasterfrom
fix/state-api-regression
Aug 20, 2025
Merged

fix(nano): state API regression after ctx.address refactor#1367
jansegre merged 1 commit intomasterfrom
fix/state-api-regression

Conversation

@jansegre
Copy link
Member

@jansegre jansegre commented Aug 19, 2025

Motivation

When we refactored ctx.address into ctx.caller_id we also introduced specialized classes Address(bytes), VertexId(bytes), etc, and those broke a if type(value) is bytes check, either way that check was not the correct way to do it.

Acceptance Criteria

  • Fix state API to return the value properly formatted (like its NCType specifies)
  • Expand the existing test to have fields of types Address, VertexId and others

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@github-actions
Copy link

github-actions bot commented Aug 19, 2025

🐰 Bencher Report

Branchfix/state-api-regression
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.82 m
(+9.61%)Baseline: 1.66 m
1.49 m
(82.11%)
1.83 m
(99.64%)
🐰 View full continuous benchmarking report in Bencher

@jansegre jansegre moved this from Todo to In Progress (Done) in Hathor Network Aug 19, 2025
@jansegre jansegre force-pushed the fix/state-api-regression branch from a63fb50 to 756cccf Compare August 19, 2025 20:21
@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.65%. Comparing base (e33ea53) to head (e0842ff).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1367      +/-   ##
==========================================
- Coverage   85.65%   85.65%   -0.01%     
==========================================
  Files         429      429              
  Lines       32440    32439       -1     
  Branches     5069     5068       -1     
==========================================
- Hits        27788    27785       -3     
- Misses       3624     3627       +3     
+ Partials     1028     1027       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jansegre jansegre moved this from In Progress (Done) to In Review (Done) in Hathor Network Aug 20, 2025
@jansegre jansegre moved this from In Review (Done) to In Progress (Done) in Hathor Network Aug 20, 2025
@jansegre jansegre force-pushed the fix/state-api-regression branch from 756cccf to 41544fd Compare August 20, 2025 00:09
@glevco glevco moved this from In Progress (Done) to In Review (WIP) in Hathor Network Aug 20, 2025
@jansegre jansegre force-pushed the fix/state-api-regression branch from 41544fd to e0842ff Compare August 20, 2025 14:03
@jansegre jansegre merged commit f0f043a into master Aug 20, 2025
7 of 8 checks passed
@jansegre jansegre deleted the fix/state-api-regression branch August 20, 2025 14:47
@github-project-automation github-project-automation bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Aug 20, 2025
This was referenced Aug 20, 2025
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants