Skip to content

fix(nano): allow import CallerId on OCBs#1364

Merged
glevco merged 1 commit intomasterfrom
fix/nano/allow-caller-id-ocb
Aug 15, 2025
Merged

fix(nano): allow import CallerId on OCBs#1364
glevco merged 1 commit intomasterfrom
fix/nano/allow-caller-id-ocb

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Aug 15, 2025

Motivation

CallerId support for OCBs was missing.

Acceptance Criteria

  • Add CallerId to allowed imports.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@github-actions
Copy link

🐰 Bencher Report

Branchfix/nano/allow-caller-id-ocb
Testbedubuntu-22.04

🚨 1 Alert

BenchmarkMeasure
Units
ViewBenchmark Result
(Result Δ%)
Upper Boundary
(Limit %)
sync-v2 (up to 20000 blocks)Latency
minutes (m)
📈 plot
🚷 threshold
🚨 alert (🔔)
2.01 m
(+21.63%)Baseline: 1.66 m
1.82 m
(110.57%)

Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
🚨 view alert (🔔)
2.01 m
(+21.63%)Baseline: 1.66 m
1.49 m
(74.00%)
1.82 m
(110.57%)

🐰 View full continuous benchmarking report in Bencher

@glevco glevco moved this from Todo to In Progress (Done) in Hathor Network Aug 15, 2025
@codecov
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.61%. Comparing base (596b9b9) to head (8e9f6c9).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1364      +/-   ##
==========================================
- Coverage   85.63%   85.61%   -0.03%     
==========================================
  Files         429      429              
  Lines       32422    32422              
  Branches     5063     5063              
==========================================
- Hits        27766    27757       -9     
- Misses       3628     3633       +5     
- Partials     1028     1032       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-project-automation github-project-automation bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Aug 15, 2025
@glevco glevco merged commit 45f5920 into master Aug 15, 2025
6 of 8 checks passed
@glevco glevco deleted the fix/nano/allow-caller-id-ocb branch August 15, 2025 20:37
@github-project-automation github-project-automation bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Aug 15, 2025
This was referenced Aug 20, 2025
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants