fix(nano): protect disabled builtin functions and fix oct#1363
Merged
Conversation
|
| Branch | fix/nano/custom-builtins |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.90 m(+13.86%)Baseline: 1.66 m | 1.50 m (79.05%) | 2.00 m (94.88%) |
a70770c to
a323770
Compare
7b72804 to
86a9986
Compare
5c590aa to
fb2ff5b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1363 +/- ##
==========================================
- Coverage 85.67% 85.63% -0.05%
==========================================
Files 429 429
Lines 32439 32444 +5
Branches 5068 5068
==========================================
- Hits 27793 27783 -10
- Misses 3616 3628 +12
- Partials 1030 1033 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msbrogli
previously approved these changes
Aug 20, 2025
7b85679 to
7645cae
Compare
jansegre
approved these changes
Aug 20, 2025
msbrogli
approved these changes
Aug 20, 2025
7645cae to
1615b27
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Improve security of custom builtins.
Acceptance Criteria
FauxImmutable.octtypo, it was incorrectly pointing toobject.False,None,True,NotImplemented,Ellipsis,__doc__,__loader__,__package__,__spec__,complex.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged