feat(nano): change ctx.address to ctx.caller_id and add support in NC types#1359
Merged
feat(nano): change ctx.address to ctx.caller_id and add support in NC types#1359
Conversation
300ab2c to
fc6b281
Compare
glevco
commented
Aug 14, 2025
|
| Branch | feat/nano/caller-id |
| Testbed | ubuntu-22.04 |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Upper Boundary (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | Latency minutes (m) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 1.84 m(+11.30%)Baseline: 1.65 m | 1.82 m (101.18%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 1.84 m(+11.30%)Baseline: 1.65 m | 1.49 m (80.86%) | 1.82 m (101.18%) |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1359 +/- ##
==========================================
- Coverage 85.65% 85.65% -0.01%
==========================================
Files 427 429 +2
Lines 32312 32422 +110
Branches 5035 5063 +28
==========================================
+ Hits 27678 27772 +94
- Misses 3616 3623 +7
- Partials 1018 1027 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msbrogli
approved these changes
Aug 14, 2025
jansegre
approved these changes
Aug 14, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
ctx.addressattribute can contain either anAddressor aContractId, but those types are not interchangeable and it makes it hard for blueprint devs to handle them. This PR changes it toctx.caller_id, with added support for storing theCallerIdtype and sending it through methods across contracts.Acceptance Criteria
Change.addresstoContext.caller_id, and add methodsget_caller_addressandget_caller_contract_id.CallerId = Address | ContractId.