fix: regression when changing the default testnet#1357
Merged
Conversation
|
Bencher Report| Branch | fix/regression-testnet-default |
| Testbed | ubuntu-22.04 |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Upper Boundary (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | Latency minutes (m) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 1.93 m(+16.97%)Baseline: 1.65 m | 1.81 m (106.33%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 1.93 m(+16.97%)Baseline: 1.65 m | 1.48 m (76.95%) | 1.81 m (106.33%) |
glevco
approved these changes
Aug 12, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1357 +/- ##
==========================================
- Coverage 85.69% 85.68% -0.02%
==========================================
Files 427 427
Lines 32305 32312 +7
Branches 5032 5035 +3
==========================================
+ Hits 27685 27687 +2
- Misses 3605 3609 +4
- Partials 1015 1016 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-project-automation
bot
moved this from In Progress (Done)
to Waiting to be deployed
in Hathor Network
This was referenced Aug 13, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix regression.
Acceptance Criteria
SKIP_VERIFICATIONshould be in testnet-hotel not testnet-golfChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged