Conversation
e8a24fa to
f6db422
Compare
|
| Branch | tests/nano/actions-order |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.85 m(+11.07%)Baseline: 1.67 m | 1.50 m (81.03%) | 2.00 m (92.56%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1354 +/- ##
==========================================
+ Coverage 85.63% 85.65% +0.01%
==========================================
Files 429 429
Lines 32450 32450
Branches 5068 5068
==========================================
+ Hits 27790 27794 +4
+ Misses 3631 3630 -1
+ Partials 1029 1026 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e216293 to
786efb7
Compare
msbrogli
approved these changes
Aug 19, 2025
786efb7 to
2eb1a25
Compare
jansegre
approved these changes
Aug 20, 2025
2eb1a25 to
aa75eb8
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Improve nano tests by making sure sending actions in different orders doesn't impact the final result.
Acceptance Criteria
test_actions.pyto run tests with different action orders in tests with more than one action.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged