Merged
Conversation
|
| Branch | feat/nano/skip-ocb-verification |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.71 m(+4.04%)Baseline: 1.65 m | 1.48 m (86.51%) | 1.81 m (94.58%) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1353 +/- ##
==========================================
- Coverage 85.69% 85.68% -0.01%
==========================================
Files 427 427
Lines 32305 32312 +7
Branches 5032 5035 +3
==========================================
+ Hits 27685 27688 +3
- Misses 3605 3607 +2
- Partials 1015 1017 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jansegre
previously approved these changes
Aug 11, 2025
b137838 to
0f6d8d4
Compare
0f6d8d4 to
89a35d8
Compare
jansegre
approved these changes
Aug 12, 2025
msbrogli
approved these changes
Aug 12, 2025
This was referenced Aug 12, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We have a single OCB on
testnet-hotelthat breaks the new OCB restrictions introduced in #1347. This PR adds a setting to bypass verification so we can update the full nodes without resetting the network. This is the skipped OCB: https://explorer.hotel.testnet.hathor.network/blueprint/detail/00000000af8c95ca9aabf5fd90ac44bd4f16d182618c357b301370ad0430c4a3Acceptance Criteria
SKIP_VERIFICATIONsettings.SKIP_VERIFICATIONontestnet-hotel.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged