Skip to content

feat: add skip verification setting#1353

Merged
glevco merged 1 commit intomasterfrom
feat/nano/skip-ocb-verification
Aug 12, 2025
Merged

feat: add skip verification setting#1353
glevco merged 1 commit intomasterfrom
feat/nano/skip-ocb-verification

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Aug 8, 2025

Motivation

We have a single OCB on testnet-hotel that breaks the new OCB restrictions introduced in #1347. This PR adds a setting to bypass verification so we can update the full nodes without resetting the network. This is the skipped OCB: https://explorer.hotel.testnet.hathor.network/blueprint/detail/00000000af8c95ca9aabf5fd90ac44bd4f16d182618c357b301370ad0430c4a3

Acceptance Criteria

  • Add new SKIP_VERIFICATION settings.
  • Configure SKIP_VERIFICATION on testnet-hotel.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Aug 8, 2025
@glevco glevco moved this from Todo to In Progress (Done) in Hathor Network Aug 8, 2025
@github-actions
Copy link

github-actions bot commented Aug 8, 2025

🐰 Bencher Report

Branchfeat/nano/skip-ocb-verification
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.71 m
(+4.04%)Baseline: 1.65 m
1.48 m
(86.51%)
1.81 m
(94.58%)
🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.68%. Comparing base (459ee06) to head (89a35d8).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
hathor/verification/verification_service.py 0.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1353      +/-   ##
==========================================
- Coverage   85.69%   85.68%   -0.01%     
==========================================
  Files         427      427              
  Lines       32305    32312       +7     
  Branches     5032     5035       +3     
==========================================
+ Hits        27685    27688       +3     
- Misses       3605     3607       +2     
- Partials     1015     1017       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jansegre
jansegre previously approved these changes Aug 11, 2025
@glevco glevco moved this from In Progress (Done) to In Review (WIP) in Hathor Network Aug 11, 2025
@glevco glevco force-pushed the feat/nano/skip-ocb-verification branch from b137838 to 0f6d8d4 Compare August 12, 2025 13:30
@glevco glevco force-pushed the feat/nano/skip-ocb-verification branch from 0f6d8d4 to 89a35d8 Compare August 12, 2025 13:36
@glevco glevco changed the title feat(nano): add skip ocb verification setting feat: add skip verification setting Aug 12, 2025
@glevco glevco merged commit fd77197 into master Aug 12, 2025
13 of 14 checks passed
@glevco glevco deleted the feat/nano/skip-ocb-verification branch August 12, 2025 16:15
@github-project-automation github-project-automation bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Aug 12, 2025
This was referenced Aug 12, 2025
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants