feat(dynamic-transaction-model): create fee tokens in nano#1350
Merged
feat(dynamic-transaction-model): create fee tokens in nano#1350
Conversation
|
| Branch | raul-oliveira/create-fee-tokens-in-nano |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.96 m(+14.53%)Baseline: 1.71 m | 1.54 m (78.58%) | 2.06 m (95.44%) |
4f3d2c3 to
1cd22f5
Compare
4c469e5 to
385e2ce
Compare
msbrogli
reviewed
Sep 10, 2025
msbrogli
reviewed
Sep 10, 2025
msbrogli
reviewed
Sep 10, 2025
msbrogli
reviewed
Sep 10, 2025
msbrogli
reviewed
Sep 10, 2025
msbrogli
reviewed
Sep 10, 2025
msbrogli
reviewed
Sep 10, 2025
msbrogli
reviewed
Sep 10, 2025
msbrogli
requested changes
Sep 10, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1350 +/- ##
==========================================
- Coverage 85.86% 85.83% -0.03%
==========================================
Files 431 432 +1
Lines 33287 33478 +191
Branches 5218 5247 +29
==========================================
+ Hits 28581 28735 +154
- Misses 3665 3693 +28
- Partials 1041 1050 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msbrogli
requested changes
Sep 11, 2025
glevco
reviewed
Sep 12, 2025
jansegre
previously approved these changes
Oct 1, 2025
glevco
previously approved these changes
Oct 1, 2025
msbrogli
previously approved these changes
Oct 2, 2025
67b2d06
raul-oliveira
commented
Oct 2, 2025
67b2d06 to
1c35bc6
Compare
glevco
reviewed
Oct 2, 2025
glevco
previously approved these changes
Oct 2, 2025
glevco
reviewed
Oct 2, 2025
1c35bc6 to
f1bfbfa
Compare
msbrogli
previously approved these changes
Oct 2, 2025
f1bfbfa to
a8c0b2f
Compare
msbrogli
approved these changes
Oct 2, 2025
glevco
approved these changes
Oct 2, 2025
a8c0b2f to
7769d16
Compare
7769d16 to
7a2a4eb
Compare
jansegre
approved these changes
Oct 2, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
To enable fee tokens in nano contracts with the create_fee_token, mint, and melt syscalls.
Acceptance Criteria
create_fee_tokenspaying with HTR by defaultcreate_fee_tokenspaying with deposit tokenTokenSyscallBalanceRuleswhich is responsible for determine the fee amounts for each token version.create_deposit_tokenssyscall to useTokenSyscallBalanceRuleschanges_tracker,call_records, andself._updated_tokens_totalsin syscalls that deals with tokens (create, mint, melt).Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged