feat(nano): generalize faux-immutability#1349
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1349 +/- ##
==========================================
+ Coverage 85.66% 85.71% +0.04%
==========================================
Files 426 427 +1
Lines 32270 32304 +34
Branches 5025 5032 +7
==========================================
+ Hits 27645 27690 +45
+ Misses 3613 3602 -11
Partials 1012 1012 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 task
caa70ac to
32b8694
Compare
91f8673 to
bf782d6
Compare
msbrogli
approved these changes
Aug 7, 2025
32b8694 to
e880df3
Compare
cffd4e5 to
ab8a7ea
Compare
msbrogli
previously approved these changes
Aug 7, 2025
e880df3 to
aca527d
Compare
jansegre
previously approved these changes
Aug 7, 2025
The base branch was changed.
ab8a7ea to
339db24
Compare
|
| Branch | feat/nano/faux-immutability |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.70 m(+3.68%)Baseline: 1.64 m | 1.48 m (86.80%) | 1.81 m (94.26%) |
msbrogli
approved these changes
Aug 8, 2025
jansegre
approved these changes
Aug 8, 2025
This was referenced Aug 12, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Generalize the immutability structures created for
NanoRNGso it can be reused on other classes.Acceptance Criteria
FauxImmutableclass, with a metaclass, that defines faux-immutability behavior for its subclasses.NanoRNGto useFauxImmutableinstead of its own ad-hoc solution. No behavior should change, except for:NanoRNG.create_with_shell(), simply doingNanoRNG()will always provide a shell.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged