Skip to content

tests(nano): test custom import#1346

Merged
glevco merged 1 commit intomasterfrom
tests/nano/custom-import
Aug 7, 2025
Merged

tests(nano): test custom import#1346
glevco merged 1 commit intomasterfrom
tests/nano/custom-import

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Aug 1, 2025

Motivation

Tie tests together, changing the mutability test to use our custom import, and making sure our custom import is used by blueprints. By doing this, we can provide a solution to the mutability of objects in our custom import, and the tests will reflect that.

Acceptance Criteria

  • Add new BlueprintTestCase.register_blueprint_contents method.
  • Add new test to make sure our custom import is being called.
  • Change test_exposed_properties to use our custom import instead of the builtin.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Aug 1, 2025
@glevco glevco requested a review from jansegre as a code owner August 1, 2025 19:26
@glevco glevco requested a review from msbrogli as a code owner August 1, 2025 19:26
@glevco glevco moved this from Todo to In Progress (Done) in Hathor Network Aug 1, 2025
@codecov
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.67%. Comparing base (3884064) to head (332e9b0).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
hathor/nanocontracts/custom_builtins.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1346      +/-   ##
==========================================
+ Coverage   85.65%   85.67%   +0.02%     
==========================================
  Files         425      425              
  Lines       32217    32217              
  Branches     5016     5016              
==========================================
+ Hits        27595    27602       +7     
+ Misses       3611     3604       -7     
  Partials     1011     1011              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jansegre jansegre deleted the branch master August 1, 2025 23:24
@jansegre jansegre closed this Aug 1, 2025
@github-project-automation github-project-automation bot moved this from In Progress (Done) to Waiting to be deployed in Hathor Network Aug 1, 2025
@glevco glevco reopened this Aug 4, 2025
@glevco glevco changed the base branch from tests/check-mutable-properties to master August 4, 2025 16:43
@glevco glevco moved this from Waiting to be deployed to In Progress (Done) in Hathor Network Aug 4, 2025
@glevco glevco force-pushed the tests/nano/custom-import branch from 5e84035 to a486843 Compare August 4, 2025 17:30
@github-actions
Copy link

github-actions bot commented Aug 4, 2025

🐰 Bencher Report

Branchtests/nano/custom-import
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.70 m
(+3.75%)Baseline: 1.64 m
1.48 m
(86.75%)
1.81 m
(94.32%)
🐰 View full continuous benchmarking report in Bencher

@glevco glevco force-pushed the tests/nano/custom-import branch 2 times, most recently from dec8cca to d0a232b Compare August 5, 2025 19:05
@msbrogli msbrogli moved this from In Progress (Done) to In Review (WIP) in Hathor Network Aug 6, 2025
@glevco glevco force-pushed the tests/nano/custom-import branch from d0a232b to 332e9b0 Compare August 6, 2025 20:14
@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Aug 6, 2025
@glevco glevco merged commit cb3772e into master Aug 7, 2025
13 of 15 checks passed
@glevco glevco deleted the tests/nano/custom-import branch August 7, 2025 00:20
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Aug 7, 2025
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Aug 7, 2025
This was referenced Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants