Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1346 +/- ##
==========================================
+ Coverage 85.65% 85.67% +0.02%
==========================================
Files 425 425
Lines 32217 32217
Branches 5016 5016
==========================================
+ Hits 27595 27602 +7
+ Misses 3611 3604 -7
Partials 1011 1011 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5e84035 to
a486843
Compare
|
| Branch | tests/nano/custom-import |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.70 m(+3.75%)Baseline: 1.64 m | 1.48 m (86.75%) | 1.81 m (94.32%) |
dec8cca to
d0a232b
Compare
1 task
msbrogli
approved these changes
Aug 6, 2025
d0a232b to
332e9b0
Compare
jansegre
approved these changes
Aug 6, 2025
This was referenced Aug 7, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Tie tests together, changing the mutability test to use our custom import, and making sure our custom import is used by blueprints. By doing this, we can provide a solution to the mutability of objects in our custom import, and the tests will reflect that.
Acceptance Criteria
BlueprintTestCase.register_blueprint_contentsmethod.test_exposed_propertiesto use our custom import instead of the builtin.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged