tests(nano): add missing tests for rng immutability#1343
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1343 +/- ##
=========================================
Coverage ? 85.59%
=========================================
Files ? 425
Lines ? 32216
Branches ? 5015
=========================================
Hits ? 27574
Misses ? 3625
Partials ? 1017 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
force-pushed
the
tests/nano/rng-immutability
branch
from
e1b4afd to
5a8b68a
Compare
jansegre
force-pushed
the
tests/check-mutable-properties
branch
4 times, most recently
from
cda71d0 to
eb64e24
Compare
glevco
force-pushed
the
tests/nano/rng-immutability
branch
from
5a8b68a to
da9997c
Compare
github-project-automation
bot
moved this from In Progress (Done)
to Waiting to be deployed
in Hathor Network
glevco
force-pushed
the
tests/nano/rng-immutability
branch
from
da9997c to
e6bd55f
Compare
|
Bencher Report| Branch | tests/nano/rng-immutability |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.68 m(+2.30%)Baseline: 1.64 m | 1.48 m (87.98%) | 1.81 m (93.00%) |
glevco
force-pushed
the
tests/nano/rng-immutability
branch
2 times, most recently
from
3271779 to
649998b
Compare
1 task
msbrogli
approved these changes
Aug 6, 2025
glevco
force-pushed
the
tests/nano/rng-immutability
branch
from
649998b to
c98f01f
Compare
jansegre
approved these changes
Aug 6, 2025
glevco
force-pushed
the
tests/nano/rng-immutability
branch
from
c98f01f to
8cf3ed3
Compare
github-project-automation
bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
This was referenced Aug 7, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Current mutability tests on
NanoRNGare incomplete, this PR adds the missing ones. And it also simplifies the frozen implementation.Acceptance Criteria
NanoRNG.__frozenattribute, to simplify the__setattr__override.test_rng_override:object.__setattr__.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged