tests(nano): fix usage of raises with match

[glevco]

Motivation

The self.assertRaises method doesn't support the match arg for checking exception messages, only the pytest.raises function. This PRs fixes all incorrect usages.

Acceptance Criteria

• Replace self.assertRaises with pytest.raises in files where the match arg is used.

Checklist

• If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

[github-actions]

Bencher Report

Branch	tests/nano/raises-match
Testbed	ubuntu-22.04

Click to view all benchmark results

Benchmark	Latency	Benchmark Result minutes (m) (Result Δ%)	Lower Boundary minutes (m) (Limit %)	Upper Boundary minutes (m) (Limit %)
sync-v2 (up to 20000 blocks)	📈 view plot 🚷 view threshold	1.70 m (+3.48%) Baseline: 1.64 m	1.48 m (86.98%)	1.80 m (94.07%)

🐰 View full continuous benchmarking report in Bencher

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.60%. Comparing base (b6c08cd) to head (f4922bc).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1341      +/-   ##
==========================================
- Coverage   85.62%   85.60%   -0.03%     
==========================================
  Files         424      424              
  Lines       32119    32119              
  Branches     4997     4997              
==========================================
- Hits        27502    27495       -7     
- Misses       3614     3616       +2     
- Partials     1003     1008       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jansegre]

Are these all cases? If they are should we add a custom linter to prevent using self.assertRaises?

[glevco]

@jansegre

Are these all cases? If they are should we add a custom linter to prevent using self.assertRaises?

Those are all cases that were using assertRaises + the match argument, but not all cases of assertRaises. I think that linter would be great, but we would need another PR to remove all usages, and since it would be a big one (even though it would be simple), I decided it was not a priority now.