tests: dynamically search for deep mutable properties#1340
Merged
Conversation
|
| Branch | tests/check-mutable-properties |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.64 m(-0.18%)Baseline: 1.64 m | 1.48 m (90.16%) | 1.80 m (90.74%) |
msbrogli
previously approved these changes
Jul 30, 2025
06120cd to
a959cd8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1340 +/- ##
==========================================
+ Coverage 85.59% 85.65% +0.05%
==========================================
Files 424 424
Lines 32119 32119
Branches 4997 4997
==========================================
+ Hits 27493 27512 +19
+ Misses 3620 3606 -14
+ Partials 1006 1001 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f243434 to
aafc3c4
Compare
msbrogli
previously approved these changes
Jul 31, 2025
aafc3c4 to
1e44f67
Compare
glevco
reviewed
Jul 31, 2025
glevco
requested changes
Jul 31, 2025
glevco
reviewed
Jul 31, 2025
glevco
reviewed
Aug 1, 2025
4d0894b to
cda71d0
Compare
msbrogli
previously approved these changes
Aug 1, 2025
cda71d0 to
eb64e24
Compare
glevco
approved these changes
Aug 1, 2025
This was referenced Aug 5, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We recently fixed some mutability cases exposed to blueprints, namely some
self.syscall.rng.*cases. But we don't have a test that dynamically checks for attributes that are possible to mutate.Acceptance Criteria
dirbuiltin andtryblocks) that does a search starting fromselfandctx: Contextlooking for attributes (including nested attributes) that would be possible to be changed from normal blueprint code (either overwritten with a new value or deleted).Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged